Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape closes the entire app instead of just dialogs #784

Closed
SimonCropp opened this issue Feb 20, 2018 · 3 comments
Closed

Escape closes the entire app instead of just dialogs #784

SimonCropp opened this issue Feb 20, 2018 · 3 comments
Labels
Bug
Milestone
1.10.0

Comments

@SimonCropp
Copy link
Contributor

in windows escape should only close a dialog
@HEskandari
Copy link
Contributor

Verified. Happens due to cfc48c8

Auto-close should happen only for dialogs.

@HEskandari HEskandari added the Bug label Feb 20, 2018
@WilliamBZA WilliamBZA added this to the 1.10.0 milestone Feb 20, 2018
@WilliamBZA WilliamBZA changed the title Escape should not close the app Escape closes the entire app instead of just dialogs Feb 20, 2018
@WilliamBZA WilliamBZA mentioned this issue Feb 20, 2018
Merged
@adamralph
Copy link
Contributor

Thanks for raising @SimonCropp. We'll fix this in 1.10.0 which will be released shortly.

@SimonCropp
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
1.10.0
Development

No branches or pull requests
4 participants
@SimonCropp @HEskandari @adamralph @WilliamBZA