Add StormHandler for logging #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d63f72.
Conflicts: streamparse/__init__.py
Conflicts: streamparse/ipc.py
…with Python logging
|
I know logging is pretty boring stuff, but any thoughts on this? |
|
Oh, I missed this PR when it opened. Really like it, @dan-blanchard. I'll merge this soon. |
|
@msukmanowsky Can you give this a review? |
|
Big 👍 on this and falls under the "why didn't I think of that?" category. Thanks @dan-blanchard! |
msukmanowsky
added a commit
that referenced
this pull request
Oct 31, 2014
Add StormHandler for logging
|
Now I've just got to add the same thing to IO::Storm using |
|
@codywilbourn I'm not sure if it was intentional, but you left this PR off the release notes for 1.1.0. It just seems like the kind of thing people might want to switch to using. 😄 |
|
Missed it looking over changes. Added to CHANGES.md as well as Github release notes. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was updating a bunch of code to use Storm for logging instead of Python logging, and I was noticing a substantial performance degradation, since the logging level was only being checked on the Storm side.
This patch adds a
StormHandlerclass that can be used to quickly update any Python code to send logging messages to Storm.