Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment badge the right way #902

Merged
merged 1 commit into from
Mar 8, 2016
Merged

Increment badge the right way #902

merged 1 commit into from
Mar 8, 2016

Conversation

flovilmart
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Current coverage is 91.70%

Merging #902 into master will not affect coverage as of 9e1031a

@@            master   #902   diff @@
=====================================
  Files           71     71       
  Stmts         4097   4100     +3
  Branches       847    847       
  Methods          0      0       
=====================================
+ Hit           3757   3760     +3
  Partial         10     10       
  Missed         330    330

Review entire Coverage Diff as of 9e1031a

Powered by Codecov. Updated on successful CI builds.

@flovilmart
Copy link
Contributor Author

Fixes #897
likely fixes #894

@flovilmart flovilmart changed the title Passes proper data to the pushController WIP: Increment badge the right way Mar 7, 2016
@flovilmart flovilmart force-pushed the flovilmart.FixPushNotifications branch from 3bf5dd1 to 5370fd9 Compare March 7, 2016 23:59
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart
Copy link
Contributor Author

maybe wait for #903

@flovilmart flovilmart changed the title WIP: Increment badge the right way Increment badge the right way Mar 8, 2016
@flovilmart flovilmart force-pushed the flovilmart.FixPushNotifications branch from 5370fd9 to c582225 Compare March 8, 2016 02:01
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart
Fixes problems related to increment badge
bf96f0d 
- name conventions are aweful in PushController
- properly looks at the badge into body.data instead of body
- We may want to refactor that as it's confusing to use a full body
@flovilmart flovilmart force-pushed the flovilmart.FixPushNotifications branch from c582225 to bf96f0d Compare March 8, 2016 03:07
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@nlutsenko
Copy link
Contributor

Awesomeness...

nlutsenko added a commit that referenced this pull request Mar 8, 2016
@nlutsenko
Merge pull request #902 from ParsePlatform/flovilmart.FixPushNotifica…
98769a2 
…tions

Increment badge the right way
@nlutsenko nlutsenko merged commit 98769a2 into master Mar 8, 2016
@nlutsenko nlutsenko deleted the flovilmart.FixPushNotifications branch March 8, 2016 04:44
@snyk-bot snyk-bot mentioned this pull request Nov 28, 2021
Merged
@Arul- Arul- mentioned this pull request Feb 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flovilmart @codecov-io @facebook-github-bot @nlutsenko