Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mounts createLiveQueryServer, fix babel induced problem #1153

Merged
merged 1 commit into from
Mar 23, 2016

Conversation

flovilmart
Copy link
Contributor

Very very urgent, a babel update seems to have broken the:

class ParseServer {
   static ParseServer() {}
}

fixes #1147
fixes #1154

After the merge, we should release 2.2.2 as this is a major break

@codecov-io
Copy link

Current coverage is 91.87%

Merging #1153 into master will increase coverage by +0.02% as of 10b9b00

@@            master   #1153   diff @@
======================================
  Files           92      92       
  Stmts         5808    5808       
  Branches      1056    1056       
  Methods          0       0       
======================================
+ Hit           5335    5336     +1
  Partial         11      11       
+ Missed         462     461     -1

Review entire Coverage Diff as of 10b9b00

Powered by Codecov. Updated on successful CI builds.

@drew-gross
Copy link
Contributor

Ah, I ran into this last night and was just about to look into it this morning. We should probably consider pinning babel.

@flovilmart
Copy link
Contributor Author

yeah, not sure about that, this fixes cleanly

@flovilmart flovilmart merged commit 16b6ec4 into master Mar 23, 2016
@flovilmart flovilmart deleted the flovilmart.fixBrokenParseServerClass branch March 31, 2016 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throwing error in index.js line 335and multiple npm erros v2.2.1 breaks LiveQuery
5 participants