Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds bootstrap.sh #1138

Merged
merged 2 commits into from
Mar 23, 2016
Merged

Adds bootstrap.sh #1138

merged 2 commits into from
Mar 23, 2016

Conversation

flovilmart
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Current coverage is 91.87%

Merging #1138 into master will not affect coverage as of 8c6e34f

@@            master   #1138   diff @@
======================================
  Files           92      92       
  Stmts         5808    5808       
  Branches      1056    1056       
  Methods          0       0       
======================================
  Hit           5336    5336       
  Partial         11      11       
  Missed         461     461       

Review entire Coverage Diff as of 8c6e34f

Powered by Codecov. Updated on successful CI builds.

echo "\n${CHECK} running npm install\n"

npm install

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, can you have it echo a curl command.. something like

Here's an example curl command you can use to test the application:

curl -X POST \
  -H "X-Parse-Application-Id: ${APP_ID}" \
  -d "{\"foo\":\"bar\"}" \
http://localhost:1337/parse/TestObject

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, mongodb is not started, should I add mongodb-runner too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo... can it ask for a connection string? with default localhost and a note that you should start it separately...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that would work too, I'll remove the auto start

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@gfosco gfosco removed their assignment Mar 23, 2016
@flovilmart flovilmart merged commit f5fdedf into master Mar 23, 2016
@flovilmart flovilmart deleted the flovilmart.bootstrap branch March 23, 2016 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants