Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application files should not be served from action.parabol.co #8948

Closed
Dschoordsch opened this issue Oct 9, 2023 · 4 comments · Fixed by #9058
Closed

Application files should not be served from action.parabol.co #8948

Dschoordsch opened this issue Oct 9, 2023 · 4 comments · Fixed by #9058
Assignees
Labels
devops DevOps-related work p1 Needs to be addressed fast. Such an issue significantly impacts the majority of users

Comments

@Dschoordsch
Copy link
Contributor

All files in the parabol-static cache are served from the webserver directly instead of the CDN.
Screenshot 2023-10-09 at 11 17 27
The 300 files amount to around 1.6 MB

@Dschoordsch Dschoordsch added the devops DevOps-related work label Oct 9, 2023
@mattkrick mattkrick self-assigned this Oct 10, 2023
@mattkrick
Copy link
Member

this is so weird because those URLs are invalid. if you look at the preview you'll see each one returns our HTML, not even the assets 🤔 . tbh not even sure how the app is working in its current state

@Dschoordsch
Copy link
Contributor Author

Looking at the static and dynamic cache we have:
static: /TeamFilterMenu_d462eccfa23818e42d74.js
dynamic: /production/build/TeamFilterMenu_d462eccfa23818e42d74.js
So we're just fetching everything into the dynamic cache, the static one seems to be fully ignored

@rafaelromcar-parabol
Copy link
Contributor

Ignored but downloaded at least once, isn't it? 🤔 I mean, that can still be a problem on releases with a lot of clients connecting at the same time. We should fix it anyway, or get rid or the static cache if that make sense

@mattkrick
Copy link
Member

I must've goofed this up when writing the service worker URLs.
As @rafaelromcar-parabol suggested, even though it's just returning a bunch of 404s, it's doing so against our webserver, so whenever a new version gets released each connected user is reconnecting & issuing like 300 requests to our webserver, which is a whole bunch of traffic all at once!

@rafaelromcar-parabol rafaelromcar-parabol added the p1 Needs to be addressed fast. Such an issue significantly impacts the majority of users label Oct 24, 2023
@Dschoordsch Dschoordsch assigned Dschoordsch and unassigned mattkrick Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops DevOps-related work p1 Needs to be addressed fast. Such an issue significantly impacts the majority of users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants