Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New new-summary view does not maintain websocket so we don't get snackbars #8913

Closed
1 task
mattkrick opened this issue Oct 3, 2023 · 1 comment · Fixed by #9231
Closed
1 task

New new-summary view does not maintain websocket so we don't get snackbars #8913

mattkrick opened this issue Oct 3, 2023 · 1 comment · Fixed by #9231
Assignees
Labels
bug p2 Needs to be addressed on a reasonable timescale

Comments

@mattkrick
Copy link
Member

I like the new new-summary view with the left nav! I think the WebSocket connection isn't persisted in that view. Can we continue to keep subscriptions open in that view now that it's more part of the dashboard view?

AC

  • finish a retro meeting, have a team member create a new check-in meeting. the viewer on /new-summary gets a snackbar saying a new meeting has started

Estimate: 2 hours

@mattkrick mattkrick added bug p2 Needs to be addressed on a reasonable timescale labels Oct 3, 2023
@mattkrick mattkrick moved this to Backlog in Bugs/Support Oct 3, 2023
@Dschoordsch Dschoordsch self-assigned this Nov 21, 2023
@Dschoordsch Dschoordsch moved this to 🏗️In Progress in 🧁Product Squad Self Raise Nov 21, 2023
@Dschoordsch
Copy link
Contributor

Websocket connection works just fine, but only the dashboards were subscribed to new meeting events.

@Dschoordsch Dschoordsch moved this from 🏗️In Progress to 👀Review in 🧁Product Squad Self Raise Nov 21, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Bugs/Support Dec 12, 2023
@github-project-automation github-project-automation bot moved this from 👀Review to ✅Done in 🧁Product Squad Self Raise Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p2 Needs to be addressed on a reasonable timescale
Projects
Status: Done
Status: ✅Done
Development

Successfully merging a pull request may close this issue.

3 participants