-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest integration after pasting GitHub / Jira link #5534
Comments
This is a great idea! Do you imagine that we'd do this in the discussion thread? First step would be a design. @ackernaut, @enriquesanchez could you suggest an estimated design effort? |
I think this feature should also be on reflections, and maybe even comment threads. I think 6 hrs. of design work should be enough. |
We might want to move to tiptap before we invest more in draftjs see #5431 |
We also need to think about what is the added value the integration brings when pasting a link. Are we going to show richer content, such as previews and embeds, that update live? |
When we detect that a link to an integration that we support has been added to a task we can display a little popup on the top right corner of the window that prompts the user to connect to said integration: I suggest the top right corner for two reasons:
The language of the popup can vary, and would love to hear if you have any suggestions for improving it, but for now I'm proposing something like:
Replace GitLab with any other integration we support. The popup should comply with the following acceptance criteria:
How should we deal with cloud vs. self-hosted integrations? When supporting both, how do we know which one the user would prefer? We don't, and I think we should ask first. #5567 has some design solutions that should also work here. |
I mentioned this in a previous comment, but I think we are going to have to follow up with clarifying what added value brings connecting an integration, particularly in these scenarios where it's only a link being pasted or added.
|
@enriquesanchez, I'm not sure how to trigger it, but our Task cards have an error state where we can show a message when something fails. I wonder instead of the modal, we put this message on the task card itself? Something like:
|
@jordanh This is great, thank you! I was not aware we had a pattern like this. Your suggestion prompted me to explore a little more and I came up with the following alternative: Considering that we adopt the pattern proposed in #5535 (comment), we can have the following flow: When a user pastes a link from an integration or 3rd party service that we support, we: 1. Allow the action of pasting a text link to happen, but at the same time we prompt the user to make a choice: a) If I continue to type or press (Maybe we add a 3rd option 2. Once a choice has been made in the previous step, then we suggest the integration: a) If I chose to paste the link as regular text b) If I chose to paste the link as an attachment: 3. From here, I can either go through with connecting the integration, or dismiss the little banner. If I go through and connect the integration, I now see richer content. a) If I pasted as link: b) If I pasted as attachment: If instead I chose to dismiss the banner, we remember that choice and don't prompt the user again. |
Design explorations done. Closing in favor of #5940. |
Issue - Enhancement
To increase integration usage, suggest integration when the user pastes a GitHub / Jira link in a Parabol task
Related conversation: https://parabol.slack.com/archives/C836NA350/p1634140455441800
Acceptance Criteria (optional)
Estimated Effort
The text was updated successfully, but these errors were encountered: