Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Meeting Permissions #4539

Closed
8 tasks
mattkrick opened this issue Jan 16, 2021 · 2 comments
Closed
8 tasks

Implement Meeting Permissions #4539

mattkrick opened this issue Jan 16, 2021 · 2 comments

Comments

@mattkrick
Copy link
Member

Today, our meeting permission model is slightly broken. Some queries require a user be a part of the meeting. Others require that the user be a part of the team. This leads to a handful of bugs & some customer complaints.

I propose that each meeting has a visibility settings, similar to templates.
Possible options are:

  • ONLY these people - select from a list (post-meeting, we could use this for things like closing it to only folks who attended)
  • Anyone who joins the team before the meeting ends
  • Anyone on the team
  • Anyone in the org
  • Anyone with a parabol account

We'll leave the UI out of it to keep the scope small.

AC

  • Each new meeting has a scope field that is one of PUBLIC, ORGANIZATION, TEAM, TEAM_BEFORE_END, INVITEES. the mutation to start the meeting includes a scope arg
  • a migration runs to add {scope: TEAM} to all existing meetings
  • Each new Team created has defaultScope: TEAM on it
  • a migration runs to add {defaultScope: TEAM} to all Team objects (putting it on Team vs. MeetingSettings because this seems more like a team culture thing than a meeting-type specific thing)
  • a mutation exists to change the defaultScope. options include PUBLIC, ORGANIZATION, TEAM, TEAM_BEFORE_END
  • when a meeting ends, timeline events & meeting summaries are sent to the invitees or team, depending on the scope
  • When querying a meeting, an error is returned if the scope is incorrect for that viewer
  • for TEAM_BEFORE_END, it requires that the teamMember.createdAt < meeting.endedAt

Estimate: 24 hours

@github-actions
Copy link
Contributor

Stale issue

@github-actions github-actions bot added the stale label Jul 26, 2021
@mattkrick
Copy link
Member Author

closing in favor of #4540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants