Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab integration #1285

Closed
jordanh opened this issue Aug 19, 2017 · 4 comments
Closed

GitLab integration #1285

jordanh opened this issue Aug 19, 2017 · 4 comments
Milestone

Comments

@jordanh
Copy link
Contributor

jordanh commented Aug 19, 2017

Issue - Enhancement

One user wrote in after our Friday Ship requesting an integration to GitLab. Opening this to track how many requests we get...

@jordanh jordanh added this to the Epic 11+: The Future milestone Aug 19, 2017
@frankdugan3
Copy link

Would this be something you'd accept as a pull request?

I took a quick peek, and it looks like you have integrations in src/server/integrations, but I'd also guess there is quite a bit more code that is coupled into other parts of the system. If you are interested in a pull request for this, would you be able to give a couple quick pointers to what I need to work on?

@jordanh
Copy link
Contributor Author

jordanh commented Mar 18, 2018

Positively @frankdugan3!

I'm not certain if you've tried our GitHub integration, but our first cut is very rudimentary. It allows a team to (1) Add GitHub as an integration provider to a team (2) add one or more repositories to the team (3) link one or more Parabol team members with their GitHub credentials for a given repository and finally, (4) when a user creates a Parabol Task card, it will generate a new GitHub issue. It's a one-way deal right now. In the future, we'll catch GH webhooks and keep our Task card state in sync with their state on GH according to a configurable rule set.

We'd probably want to start in the same place with GitLab.

I'd suggest we break this down into a set of smaller PRs, and integrate them one-by-one. I'd be happy to write issues for them, one at a time if you like. The first would be something along the lines of:

  • /team/:teamId/settings/integrations route extended to list GitLab integration and hidden behind a release flag in src/universal/releaseFlags.js
  • "Link My Account" flow implemented for GitLab
    • Including set of mutations in server/graphql/mutations/*GitHub*

Would you like to take a crack at this first step?

@frankdugan3
Copy link

@jordanh Hmm, I think it may wait until the GH integration is a little more mature before tackling GitLab.

@jordanh
Copy link
Contributor Author

jordanh commented Aug 1, 2018

Closing this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants