Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template assets not being uploaded to AWS S3 bucket #10662

Closed
rafaelromcar-parabol opened this issue Jan 10, 2025 · 0 comments · Fixed by #10661
Closed

Template assets not being uploaded to AWS S3 bucket #10662

rafaelromcar-parabol opened this issue Jan 10, 2025 · 0 comments · Fixed by #10661
Assignees
Labels

Comments

@rafaelromcar-parabol
Copy link
Contributor

Issue - Bug

  • How serious is the bug? P2
  • OS: macOS / Linux / Windows / ?
  • Browser: Chrome / Safari / Lynx / ? + version
  • Node version: node --version
  • NPM version: npm --version

It affects all newly created instances and any new template that might be added, if the environment uses AWS S3. Example:

ServerID 145                                                                                                                                                                                                       
{"time":"2025-01-09T13:35:08.083Z","level":"info","message":"🚀 Predeploy Started v8.16.0 sha:c32591230eec6a125cebc1fa592158045c70a79f []"}                                                                        
{"time":"2025-01-09T13:35:08.087Z","level":"info","message":"🐘 Postgres Migration Started []"}                                                                                                                    
{"time":"2025-01-09T13:35:08.087Z","level":"info","message":"🔩 Postgres Extension Checks Started []"}                                                                                                             
{"time":"2025-01-09T13:35:08.087Z","level":"info","message":"   pgvector []"}                                                                                                                                      
{"time":"2025-01-09T13:35:08.192Z","level":"info","message":"🔩 Postgres Extension Checks Completed []"}                                                                                                           
{"time":"2025-01-09T13:35:09.984Z","level":"info","message":"  ✅ Migration: 2025-01-08T00:27:52.203Z_init []"}                                                                                                    
{"time":"2025-01-09T13:35:09.985Z","level":"info","message":"🐘 Postgres Migration Complete []"}                                                                                                                   
{"time":"2025-01-09T13:35:09.986Z","level":"info","message":"🔗 QueryMap Persistence Started []"}                                                                                                                  
{"time":"2025-01-09T13:35:09.992Z","level":"info","message":"⛓️ Prime Integrationgs Started []"}                                                                                                                    
{"time":"2025-01-09T13:35:09.994Z","level":"info","message":"⛅️ Push to CDN Started []"}                                                                                                                           
{"time":"2025-01-09T13:35:10.168Z","level":"info","message":"🔗 QueryMap Persistence Complete: 271 records added []"}                                                                                              
{"time":"2025-01-09T13:35:10.482Z","level":"info","message":"⛓️ Prime Integrations Complete []"}                                                                                                                    
{"time":"2025-01-09T13:35:12.225Z","level":"info","message":"⛅️ Uploaded 223 client assets to CDN []"}                                                                                                             
{"time":"2025-01-09T13:35:12.400Z","level":"info","message":"⛅️ Server upload complete. Pushed 0 assets to CDN []"}                                                                                                
{"time":"2025-01-09T13:35:12.400Z","level":"info","message":"⛅️ Push to CDN Complete []"}                                                                                                                          
{"time":"2025-01-09T13:35:12.401Z","level":"info","message":"🚀 Predeploy Complete []"}                                                                                                                            
Stream closed EOF for od-remove-draft-js/parabol-predeploy-sxlzj (parabol-predeploy)

After running that:

  • Files in build folder were pushed
  • Files are pushed to store/User
  • Nothing is in store/Organization as it simply does not exist. And all template images fail to be pulled as they are not found in the bucket.

Acceptance Criteria (optional)

PreDeploy uploads files where and when it should, and users can query them correctly.

Triage is performed to find the root cause of the bug, timeboxed to ~1 hour.

Estimated effort: 1 hour to triage. More if root cause is already identified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant