Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Already at this stage #10410

Closed
rafaelromcar-parabol opened this issue Oct 24, 2024 · 6 comments
Closed

Already at this stage #10410

rafaelromcar-parabol opened this issue Oct 24, 2024 · 6 comments
Labels
bug p2 Needs to be addressed on a reasonable timescale

Comments

@rafaelromcar-parabol
Copy link
Contributor

rafaelromcar-parabol commented Oct 24, 2024

Issue - Bug

  • How serious is the bug? P2
  • OS: macOS / Linux / Windows / ? -
  • Browser: Chrome / Safari / Lynx / ? + version -
  • Node version: node --version v20.11.0
  • NPM version: npm --version

ACTION-PRODUCTION-G8Z

We might have started seeing this error on Oct 9th at around 00:00, right after deploying v7.50.3 to production, but it's hard to tell as we keep only 14 days of Datadog logs

SEND TO SENTRY Error: Already at this stage                                                                                                                                                                        
    at resolve (/home/node/parabol/dist/gqlExecutor.js:96530:53)                                                                                                                                                   
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)                                                                                                                                  
    at async Object.MutationnavigateMeetingResolver (/home/node/parabol/dist/gqlExecutor.js:126133:22)

Acceptance Criteria (optional)

Users can:

  • Do this
  • Do that
  • Cannot do that
    Triage is performed to find the root cause of the bug, timeboxed to ~1 hour.

Estimated effort: 1 hour to triage. More if root cause is already identified.

@Dschoordsch
Copy link
Contributor

Sentry Issue: ACTION-PRODUCTION-G8Z

@rafaelromcar-parabol
Copy link
Contributor Author

Happened 5.55k times in the last two weeks. Fixing this would make our logs much easier to read

@jordanh jordanh added this to Product Nov 18, 2024
@github-project-automation github-project-automation bot moved this to To triage in Product Nov 18, 2024
@jordanh jordanh moved this from To triage to Backlog in Product Nov 18, 2024
@jordanh jordanh added the p2 Needs to be addressed on a reasonable timescale label Nov 18, 2024
@jordanh
Copy link
Contributor

jordanh commented Nov 18, 2024

Added this to the backlog for investigation

@rafaelromcar-parabol
Copy link
Contributor Author

Hey there! I managed to reproduce this error on Staging. Very easy to do! Check my Loom https://www.loom.com/share/318404fe32434ce386fec7e4b144e8db

As I say on the video, that log line was introduced by @mattkrick during the NewMeeting Phase 3 migration. It might be useful for something, but I'm not quite sure for what, and right now it's adding a lot of noise. @mattkrick do you remember why you added that? Should we keep it?

@mattkrick
Copy link
Member

oh that's great.
yeah, we should keep the line because it tells us that the client is sending messages to the server that aren't necessary, now that we know the root cause (thank you!) we can prevent the client from sending them in the first place

@mattkrick
Copy link
Member

fixed in #10575

@github-project-automation github-project-automation bot moved this from Backlog to Done in Product Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p2 Needs to be addressed on a reasonable timescale
Projects
Status: Done
Status: Done
Development

No branches or pull requests

4 participants