Added support for OpenACC #416

vikram8128 · 2022-06-28T01:43:05Z

…pilers.

codecov · 2022-06-28T02:29:30Z

Codecov Report

Merging #416 (72ead21) into unstable (f683c83) will decrease coverage by 0.48%.
The diff coverage is 61.53%.

@@             Coverage Diff              @@
##           unstable     #416      +/-   ##
============================================
- Coverage     69.50%   69.02%   -0.49%     
============================================
  Files            98       98              
  Lines          8665     8687      +22     
  Branches       1707     1711       +4     
============================================
- Hits           6023     5996      -27     
- Misses         2126     2175      +49     
  Partials        516      516

Flag	Coverage Δ
CI	`69.02% <61.53%> (-0.49%)`	⬇️
unittests	`69.02% <61.53%> (-0.49%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/taucmdr/cli/commands/initialize.py	`79.72% <ø> (ø)`
packages/taucmdr/model/application.py	`84.00% <ø> (ø)`
packages/taucmdr/model/experiment.py	`74.00% <ø> (ø)`
packages/taucmdr/cf/software/tau_installation.py	`54.53% <33.33%> (-0.67%)`	⬇️
...ackages/taucmdr/cf/software/libelf_installation.py	`71.42% <45.45%> (-28.58%)`	⬇️
...kages/taucmdr/cf/software/binutils_installation.py	`55.29% <50.00%> (ø)`
packages/taucmdr/cf/software/installation.py	`62.99% <50.00%> (-1.53%)`	⬇️
...ages/taucmdr/cf/software/libunwind_installation.py	`58.18% <50.00%> (ø)`
packages/taucmdr/cf/software/pdt_installation.py	`60.78% <66.66%> (ø)`
packages/taucmdr/cf/software/papi_installation.py	`60.78% <75.00%> (+0.78%)`	⬆️
... and 8 more

packages/taucmdr/cf/software/tau_installation.py

packages/taucmdr/model/target.py

packages/taucmdr/cli/commands/trial/tests/test_create.py

zbeekman

@vikram8128 Great work! Things look really good. If you could please address @nchaimov and my review comments and make a few small changes I'd appreciate it. I need to look at the eid to path change a little bit more to refresh myself on where that's used and what the side effects/consequences of that change might be, and any additional comments about why you'd like to make that change would be particularly helpful in getting myself back up to speed.

.testfiles/timer.h

packages/taucmdr/cf/software/libelf_installation.py

packages/taucmdr/cf/software/papi_installation.py

packages/taucmdr/cli/commands/experiment/tests/test_create.py

packages/taucmdr/cli/commands/trial/tests/test_create.py

packages/taucmdr/cli/commands/trial/tests/test_export.py

packages/taucmdr/model/target.py

packages/taucmdr/tests/__init__.py

packages/taucmdr/cf/software/libelf_installation.py

packages/taucmdr/cli/commands/trial/tests/test_create.py

packages/taucmdr/cf/software/papi_installation.py

packages/taucmdr/cf/software/tests/test_papi_installation.py

packages/taucmdr/cli/commands/trial/tests/test_create.py

packages/taucmdr/cli/commands/trial/tests/test_export.py

packages/taucmdr/cf/software/libelf_installation.py

Neated up testing skip cases

packages/taucmdr/cf/software/installation.py

nchaimov

All of my concerns have been addressed. Thanks, @vikram8128!

@zbeekman When you get an opportunity, can you check to see if there's anything more to do from your perspective?

zbeekman

Great work @vikram8128! One minor suggestion/edit but it's ready to merge other than that. I can make the change & merge the PR if you like, just let me know.

packages/taucmdr/cf/software/libelf_installation.py

Co-authored-by: Izaak "Zaak" Beekman <zbeekman@gmail.com>

zbeekman

LGTM!

github-actions · 2022-06-30T18:52:17Z

Pylint Output

Report

8789 statements analysed.

Statistics by type

type	number	old number	difference	%documented	%badname
module	99	NC	NC	100.00	0.00
class	129	NC	NC	99.22	0.00
method	695	NC	NC	98.71	0.86
function	115	NC	NC	97.39	0.87

20746 lines have been analyzed

Raw metrics

type	number	%	previous	difference
code	10676	51.46	NC	NC
docstring	5420	26.13	NC	NC
comment	2949	14.21	NC	NC
empty	1701	8.20	NC	NC

Duplication

	now	previous	difference
nb duplicated lines	0	NC	NC
percent duplicated lines	0.000	NC	NC

Messages by category

type	number	previous	difference
convention	117	NC	NC
refactor	46	NC	NC
warning	56	NC	NC
error	0	NC	NC

Messages

message id	occurrences
import-outside-toplevel	81
unspecified-encoding	12
missing-function-docstring	12
arguments-differ	12
line-too-long	10
consider-using-with	10
no-else-return	9
inconsistent-return-statements	8
unnecessary-lambda-assignment	6
invalid-name	5
useless-super-delegation	3
unused-variable	3
too-many-nested-blocks	3
logging-fstring-interpolation	3
fixme	3
consider-using-generator	3
bad-indentation	3
arguments-renamed	3
use-implicit-booleaness-not-len	2
unused-import	2
unused-argument	2
too-many-locals	2
redefined-outer-name	2
logging-not-lazy	2
invalid-overridden-method	2
use-list-literal	1
use-dict-literal	1
use-a-generator	1
unnecessary-list-index-lookup	1
too-many-public-methods	1
simplifiable-if-expression	1
redefined-builtin	1
raising-format-tuple	1
raise-missing-from	1
no-else-raise	1
no-else-continue	1
missing-class-docstring	1
consider-using-in	1
consider-using-dict-comprehension	1
condition-evals-to-constant	1
broad-except	1

Your code has been rated at 9.50/10

Per-file output (click to expand)

************* Module /home/runner/work/taucmdr/taucmdr/pylintrc
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: E0015: Unrecognized option found: optimize-ast, files-output, no-space-check, bad-functions, function-name-hint, variable-name-hint, const-name-hint, attr-name-hint, argument-name-hint, class-attribute-name-hint, inlinevar-name-hint, class-name-hint, module-name-hint, method-name-hint (unrecognized-option)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'import-star-module-level' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'oct-method' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'print-statement' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'unpacking-in-except' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'parameter-unpacking' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'backtick' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'old-raise-syntax' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'dict-view-method' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'dict-iter-method' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'metaclass-assignment' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'next-method-called' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'raising-string' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'indexing-exception' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'raw_input-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'long-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'file-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'execfile-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'coerce-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'cmp-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'buffer-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'basestring-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'apply-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'filter-builtin-not-iterating' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'using-cmp-argument' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'range-builtin-not-iterating' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'no-absolute-import' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'old-division' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'cmp-method' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'reload-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'zip-builtin-not-iterating' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'intern-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'unichr-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'reduce-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'standarderror-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'unicode-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'xrange-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'coerce-method' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'delslice-method' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'getslice-method' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'setslice-method' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'input-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'round-builtin' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'hex-method' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'nonzero-method' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'map-builtin-not-iterating' was removed from pylint, see https://github.com/PyCQA/pylint/pull/4942. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: R0022: Useless option value for '--disable', 'no-self-use' was moved to an optional extension, see https://pylint.pycqa.org/en/latest/whatsnew/2/2.14/summary.html#removed-checkers. (useless-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'old-octal-literal' (unknown-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'old-ne-operator' (unknown-option-value)
/home/runner/work/taucmdr/taucmdr/pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'long-suffix' (unknown-option-value)
************* Module taucmdr.error
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/error.py:75:4: C0116: Missing function or method docstring (missing-function-docstring)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/error.py:122:20: R1734: Consider using [] instead of list() (use-list-literal)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/error.py:168:8: C0415: Import outside toplevel (taucmdr.cli.commands.project.create.COMMAND) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/error.py:169:8: C0415: Import outside toplevel (taucmdr.cli.commands.project.select.COMMAND) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/error.py:170:8: C0415: Import outside toplevel (taucmdr.cli.commands.project.list.COMMAND) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/error.py:182:8: C0415: Import outside toplevel (taucmdr.cli.commands.select.COMMAND) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/error.py:183:8: C0415: Import outside toplevel (taucmdr.cli.commands.experiment.create.COMMAND) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/error.py:184:8: C0415: Import outside toplevel (taucmdr.cli.commands.dashboard.COMMAND) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/error.py:185:8: C0415: Import outside toplevel (taucmdr.cli.commands.project.list.COMMAND) (import-outside-toplevel)
************* Module taucmdr
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/__init__.py:103:4: C0415: Import outside toplevel (platform) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/__init__.py:104:4: C0415: Import outside toplevel (socket) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/__init__.py:105:4: C0415: Import outside toplevel (datetime.datetime) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/__init__.py:106:4: C0415: Import outside toplevel (taucmdr.logger) (import-outside-toplevel)
************* Module taucmdr.progress
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/progress.py:45:9: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/progress.py:130:8: C0415: Import outside toplevel (taucmdr.util) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/progress.py:142:8: C0415: Import outside toplevel (taucmdr.util) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/progress.py:177:4: C0116: Missing function or method docstring (missing-function-docstring)
************* Module taucmdr.mvc.controller
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/mvc/controller.py:54:0: C0116: Missing function or method docstring (missing-function-docstring)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/mvc/controller.py:270:19: R1727: Boolean condition ''model' or 'collection' in self.model.attributes[attr]' will always evaluate to ''model'' (condition-evals-to-constant)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/mvc/controller.py:409:27: C3001: Lambda expression assigned to a variable. Define a function using the "def" keyword instead. (unnecessary-lambda-assignment)
************* Module taucmdr.mvc.model
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/mvc/model.py:44:40: R1735: Consider using {} instead of dict() (use-dict-literal)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/mvc/model.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/mvc/model.py:172:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/mvc/model.py:586:19: C3001: Lambda expression assigned to a variable. Define a function using the "def" keyword instead. (unnecessary-lambda-assignment)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/mvc/model.py:603:8: C0415: Import outside toplevel (taucmdr.cli.arguments.ArgumentsNamespace) (import-outside-toplevel)
************* Module taucmdr.logger
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/logger.py:112:8: C0415: Import outside toplevel (ctypes.windll, ctypes.create_string_buffer) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/logger.py:120:8: C0415: Import outside toplevel (struct) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/logger.py:138:8: C0415: Import outside toplevel (subprocess) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/logger.py:139:15: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/logger.py:143:15: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/logger.py:167:12: C0415: Import outside toplevel (fcntl) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/logger.py:168:12: C0415: Import outside toplevel (termios) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/logger.py:169:12: C0415: Import outside toplevel (struct) (import-outside-toplevel)
************* Module taucmdr.cli
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/__init__.py:230:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
************* Module taucmdr.cli.arguments
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/arguments.py:474:0: C0301: Line too long (123/120) (line-too-long)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/arguments.py:306:32: R1728: Consider using a generator instead 'max(len(util.uncolor_text(s)) for s in invocations)' (consider-using-generator)
************* Module taucmdr.cli.cli_view
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/cli_view.py:171:12: C0415: Import outside toplevel (taucmdr.cli.commands.project.edit.COMMAND) (import-outside-toplevel)
************* Module taucmdr.cli.commands.__main__
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/commands/__main__.py:66:17: C3001: Lambda expression assigned to a variable. Define a function using the "def" keyword instead. (unnecessary-lambda-assignment)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/commands/__main__.py:136:8: C0415: Import outside toplevel (taucmdr.model.project.Project) (import-outside-toplevel)
************* Module taucmdr.util
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:80:12: W0622: Redefining built-in 'dir' (redefined-builtin)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:82:12: W0612: Unused variable 'src' (unused-variable)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:110:11: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:144:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:207:15: C3001: Lambda expression assigned to a variable. Define a function using the "def" keyword instead. (unnecessary-lambda-assignment)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:263:49: W0612: Unused variable 'progress_bar' (unused-variable)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:293:19: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:329:14: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:378:15: C0103: Variable name "v" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:379:12: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:391:12: C0103: Variable name "v" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:497:4: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:507:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:507:21: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:561:15: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:633:15: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:683:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/util.py:779:11: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
************* Module taucmdr.cli.commands.dashboard
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/commands/dashboard.py:68:16: C0415: Import outside toplevel (taucmdr.cli.commands.project.create.COMMAND) (import-outside-toplevel)
************* Module taucmdr.cli.commands.select
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/commands/select.py:117:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
************* Module taucmdr.cli.commands.target.metrics
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/commands/target/metrics.py:65:21: R1728: Consider using a generator instead 'max(len(row[0]) for row in rows)' (consider-using-generator)
************* Module taucmdr.cli.commands.trial.renumber
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/commands/trial/renumber.py:80:8: W1201: Use lazy % formatting in logging functions (logging-not-lazy)
************* Module taucmdr.cli.commands.trial.delete
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/commands/trial/delete.py:65:30: R1736: Unnecessary list index lookup, use '_' instead (unnecessary-list-index-lookup)
************* Module taucmdr.cli.commands.trial.list
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/commands/trial/list.py:63:11: R1714: Consider merging these comparisons with "in" to "key in ('environment', 'output')" (consider-using-in)
************* Module taucmdr.cli.commands.target.edit
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/commands/target/edit.py:109:8: C0415: Import outside toplevel (taucmdr.cli.commands.target.copy.COMMAND) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/commands/target/edit.py:110:8: C0415: Import outside toplevel (taucmdr.cli.commands.experiment.delete.COMMAND) (import-outside-toplevel)
************* Module taucmdr.cli.commands.project.edit
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/commands/project/edit.py:163:8: C0415: Import outside toplevel (taucmdr.cli.commands.project.list.COMMAND) (import-outside-toplevel)
************* Module taucmdr.cli.commands.target.create
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/commands/target/create.py:108:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
************* Module taucmdr.cli.commands.experiment.edit
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cli/commands/experiment/edit.py:38:0: C0115: Missing class docstring (missing-class-docstring)
************* Module taucmdr.cf.objects
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/objects.py:66:0: W0613: Unused argument 'args' (unused-argument)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/objects.py:66:0: W0613: Unused argument 'kwargs' (unused-argument)
************* Module taucmdr.cf.storage.levels
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/levels.py:64:0: C0116: Missing function or method docstring (missing-function-docstring)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/levels.py:43:0: W0611: Unused import os (unused-import)
************* Module taucmdr.cf.storage.sqlite3_project
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_project.py:59:8: C0415: Import outside toplevel (taucmdr.cf.storage.levels.USER_STORAGE) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_project.py:69:12: W0621: Redefining name 'err' from outer scope (line 62) (redefined-outer-name)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_project.py:73:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_project.py:105:8: C0415: Import outside toplevel (taucmdr.cf.storage.levels.USER_STORAGE, taucmdr.cf.storage.levels.SYSTEM_STORAGE) (import-outside-toplevel)
************* Module taucmdr.cf.platforms
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/platforms.py:77:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/platforms.py:79:20: R1724: Unnecessary "elif" after "continue", remove the leading "el" from "elif" (no-else-continue)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/platforms.py:125:16: C0415: Import outside toplevel (platform) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/platforms.py:179:16: C0415: Import outside toplevel (platform) (import-outside-toplevel)
************* Module taucmdr.cf.storage.local_file
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/local_file.py:72:27: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/local_file.py:72:27: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/local_file.py:199:4: W0236: Method 'prefix' was expected to be 'method', found it instead as 'property' (invalid-overridden-method)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/local_file.py:227:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
************* Module taucmdr.cf.storage.project
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/project.py:79:8: C0415: Import outside toplevel (taucmdr.cf.storage.levels.USER_STORAGE) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/project.py:89:12: W0621: Redefining name 'err' from outer scope (line 82) (redefined-outer-name)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/project.py:93:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/project.py:125:8: C0415: Import outside toplevel (taucmdr.cf.storage.levels.USER_STORAGE, taucmdr.cf.storage.levels.SYSTEM_STORAGE) (import-outside-toplevel)
************* Module taucmdr.cf.storage.sqlite3_file
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_file.py:535:9: W0511: TODO This could be made more efficient if we make this function less general. (fixme)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_file.py:678:13: W0511: TODO Change this to use a single operation (fixme)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_file.py:109:16: W1203: Use lazy % formatting in logging functions (logging-fstring-interpolation)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_file.py:133:12: W1203: Use lazy % formatting in logging functions (logging-fstring-interpolation)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_file.py:273:4: C0116: Missing function or method docstring (missing-function-docstring)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_file.py:292:4: C0116: Missing function or method docstring (missing-function-docstring)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_file.py:464:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_file.py:497:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_file.py:538:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_file.py:569:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/sqlite3_file.py:671:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return)
************* Module taucmdr.cf.software.scorep_installation
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/scorep_installation.py:208:4: W0221: Number of parameters was 3 in 'AutotoolsInstallation.configure' and is now 2 in overridden 'ScorepInstallation.configure' method (arguments-differ)
************* Module taucmdr.cf.software.libelf_installation
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/libelf_installation.py:63:0: C0301: Line too long (148/120) (line-too-long)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/libelf_installation.py:61:4: W0221: Number of parameters was 3 in 'AutotoolsInstallation.configure' and is now 2 in overridden 'LibelfInstallation.configure' method (arguments-differ)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/libelf_installation.py:34:0: W0611: Unused import os (unused-import)
************* Module taucmdr.cf.storage.storage_dispatch
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/storage/storage_dispatch.py:156:4: W0236: Method 'prefix' was expected to be 'method', found it instead as 'property' (invalid-overridden-method)
************* Module taucmdr.cf.software.libdwarf_installation
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/libdwarf_installation.py:53:4: W0221: Number of parameters was 3 in 'AutotoolsInstallation.configure' and is now 2 in overridden 'LibdwarfInstallation.configure' method (arguments-differ)
************* Module taucmdr.cf.software.libunwind_installation
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/libunwind_installation.py:73:4: W0221: Number of parameters was 3 in 'AutotoolsInstallation.configure' and is now 2 in overridden 'LibunwindInstallation.configure' method (arguments-differ)
************* Module taucmdr.cf.compiler.__init__
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/compiler/__init__.py:552:0: C0301: Line too long (127/120) (line-too-long)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/compiler/__init__.py:772:0: W0311: Bad indentation. Found 14 spaces, expected 16 (bad-indentation)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/compiler/__init__.py:773:0: W0311: Bad indentation. Found 18 spaces, expected 20 (bad-indentation)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/compiler/__init__.py:774:0: W0311: Bad indentation. Found 18 spaces, expected 20 (bad-indentation)
************* Module taucmdr.cf.compiler
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/compiler/__init__.py:139:8: C0415: Import outside toplevel (taucmdr.cf.platforms.HOST_TAU_MAGIC) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/compiler/__init__.py:298:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/compiler/__init__.py:662:4: C0116: Missing function or method docstring (missing-function-docstring)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/compiler/__init__.py:732:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/compiler/__init__.py:849:4: W0221: Number of parameters was 1 in 'KeyedRecord.keys' and is now 1 in overridden 'InstalledCompilerSet.keys' method (arguments-differ)
************* Module taucmdr.cf.software.pdt_installation
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/pdt_installation.py:224:4: W0221: Number of parameters was 3 in 'AutotoolsInstallation.configure' and is now 2 in overridden 'PdtInstallation.configure' method (arguments-differ)
************* Module taucmdr.cf.software.binutils_installation
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/binutils_installation.py:67:4: W0221: Number of parameters was 3 in 'AutotoolsInstallation.configure' and is now 2 in overridden 'BinutilsInstallation.configure' method (arguments-differ)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/binutils_installation.py:68:8: C0415: Import outside toplevel (taucmdr.cf.platforms.DARWIN, taucmdr.cf.platforms.IBM_BGP, taucmdr.cf.platforms.IBM_BGQ, taucmdr.cf.platforms.INTEL_KNC) (import-outside-toplevel)
************* Module taucmdr.cf.software.papi_installation
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/papi_installation.py:81:4: W0221: Number of parameters was 3 in 'AutotoolsInstallation.configure' and is now 2 in overridden 'PapiInstallation.configure' method (arguments-differ)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/papi_installation.py:82:8: C0103: Variable name "cc" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
************* Module taucmdr.cf.software.installation
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/installation.py:398:8: C0415: Import outside toplevel (taucmdr.cf.software) (import-outside-toplevel)
************* Module taucmdr.model.measurement
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/measurement.py:53:4: C0415: Import outside toplevel (taucmdr.model.project.Project) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/measurement.py:54:4: C0415: Import outside toplevel (taucmdr.model.target.Target) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/measurement.py:55:4: C0415: Import outside toplevel (taucmdr.model.application.Application) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/measurement.py:56:4: C0415: Import outside toplevel (taucmdr.cf.platforms.HOST_OS, taucmdr.cf.platforms.DARWIN, taucmdr.cf.platforms.IBM_CNK) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/measurement.py:57:4: C0415: Import outside toplevel (taucmdr.cf.compiler.mpi.MPI_CC, taucmdr.cf.compiler.mpi.MPI_CXX, taucmdr.cf.compiler.mpi.MPI_FC) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/measurement.py:58:4: C0415: Import outside toplevel (taucmdr.cf.compiler.cuda.CUDA_CXX) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/measurement.py:59:4: C0415: Import outside toplevel (taucmdr.cf.compiler.shmem.SHMEM_CC, taucmdr.cf.compiler.shmem.SHMEM_CXX, taucmdr.cf.compiler.shmem.SHMEM_FC) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/measurement.py:314:44: C1802: Do not use `len(SEQUENCE)` without comparison to determine if a sequence is empty (use-implicit-booleaness-not-len)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/measurement.py:529:8: C0415: Import outside toplevel (taucmdr.error.ImmutableRecordError) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/measurement.py:530:8: C0415: Import outside toplevel (taucmdr.model.experiment.Experiment) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/measurement.py:564:8: W0612: Unused variable 'err' (unused-variable)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/measurement.py:574:8: C0415: Import outside toplevel (taucmdr.error.ImmutableRecordError) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/measurement.py:575:8: C0415: Import outside toplevel (taucmdr.model.experiment.Experiment) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/measurement.py:605:8: C0415: Import outside toplevel (taucmdr.model.project.Project) (import-outside-toplevel)
************* Module taucmdr.model.experiment
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:50:4: C0415: Import outside toplevel (taucmdr.model.target.Target) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:51:4: C0415: Import outside toplevel (taucmdr.model.application.Application) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:52:4: C0415: Import outside toplevel (taucmdr.model.measurement.Measurement) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:108:4: W0237: Parameter 'key' has been renamed to 'keys' in overridden 'ExperimentController.one' method (arguments-renamed)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:116:4: W0221: Number of parameters was 2 in 'Controller.count' and is now 1 in overridden 'ExperimentController.count' method (arguments-differ)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:126:4: W0221: Number of parameters was 3 in 'Controller.exists' and is now 2 in overridden 'ExperimentController.exists' method (arguments-differ)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:133:4: W0235: Useless super delegation in method 'create' (useless-super-delegation)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:136:4: W0235: Useless super delegation in method 'update' (useless-super-delegation)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:139:4: W0235: Useless super delegation in method 'unset' (useless-super-delegation)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:142:4: W0221: Number of parameters was 3 in 'Controller.delete' and is now 2 in overridden 'ExperimentController.delete' method (arguments-differ)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:241:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise ConfigurationError('Cannot create directory %r' % self.prefix, 'Check that you have `write` access') from exc' (raise-missing-from)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:252:15: R1728: Consider using a generator instead 'sum(int(trial.get('data_size', 0)) for trial in self.populate('trials'))' (consider-using-generator)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:271:8: C0415: Import outside toplevel (taucmdr.cf.software.tau_installation.TauInstallation) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:434:4: C0116: Missing function or method docstring (missing-function-docstring)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:435:8: C0415: Import outside toplevel (taucmdr.cf.software.tau_installation.TauInstallation) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/experiment.py:534:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
************* Module taucmdr.model.application
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/application.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/application.py:50:4: C0415: Import outside toplevel (taucmdr.model.project.Project) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/application.py:51:4: C0415: Import outside toplevel (taucmdr.model.target.Target) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/application.py:52:4: C0415: Import outside toplevel (taucmdr.model.measurement.Measurement) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/application.py:53:4: C0415: Import outside toplevel (taucmdr.cf.platforms.DARWIN, taucmdr.cf.platforms.HOST_OS, taucmdr.cf.platforms.CRAY_CNL) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/application.py:185:8: C0415: Import outside toplevel (taucmdr.error.ImmutableRecordError) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/application.py:186:8: C0415: Import outside toplevel (taucmdr.model.experiment.Experiment) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/application.py:204:8: C0415: Import outside toplevel (taucmdr.error.ImmutableRecordError) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/application.py:205:8: C0415: Import outside toplevel (taucmdr.model.experiment.Experiment) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/application.py:226:8: C0415: Import outside toplevel (taucmdr.model.project.Project) (import-outside-toplevel)
************* Module taucmdr.model.project
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/project.py:47:4: C0415: Import outside toplevel (taucmdr.model.target.Target) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/project.py:48:4: C0415: Import outside toplevel (taucmdr.model.application.Application) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/project.py:49:4: C0415: Import outside toplevel (taucmdr.model.measurement.Measurement) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/project.py:50:4: C0415: Import outside toplevel (taucmdr.model.experiment.Experiment) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/project.py:97:4: W0221: Number of parameters was 3 in 'Controller.delete' and is now 2 in overridden 'ProjectController.delete' method (arguments-differ)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/project.py:142:8: C0415: Import outside toplevel (taucmdr.model.experiment.Experiment) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/project.py:143:8: C0415: Import outside toplevel (taucmdr.model.compiler.Compiler) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/project.py:149:8: R1702: Too many nested blocks (8/5) (too-many-nested-blocks)
************* Module taucmdr.model.trial
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/trial.py:58:4: C0415: Import outside toplevel (taucmdr.model.experiment.Experiment) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/trial.py:351:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/trial.py:529:4: R0914: Too many local variables (23/20) (too-many-locals)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/trial.py:587:24: W0715: Exception arguments suggest string formatting might be intended (raising-format-tuple)
************* Module taucmdr.model.target
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:663:0: C0301: Line too long (157/120) (line-too-long)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:751:9: W0511: FIXME: not implemented (fixme)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:158:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:168:0: R0914: Too many local variables (24/20) (too-many-locals)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:177:4: C0415: Import outside toplevel (taucmdr.model.project.Project) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:178:4: C0415: Import outside toplevel (taucmdr.cli.arguments.ParsePackagePathAction) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:179:4: C0415: Import outside toplevel (taucmdr.cf.compiler.host.CC, taucmdr.cf.compiler.host.CXX, taucmdr.cf.compiler.host.FC, taucmdr.cf.compiler.host.UPC, taucmdr.cf.compiler.host.INTEL, taucmdr.cf.compiler.host.PGI, taucmdr.cf.compiler.host.NVHPC, taucmdr.cf.compiler.host.GNU) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:180:4: C0415: Import outside toplevel (taucmdr.cf.compiler.mpi.MPI_CC, taucmdr.cf.compiler.mpi.MPI_CXX, taucmdr.cf.compiler.mpi.MPI_FC, taucmdr.cf.compiler.mpi.INTEL) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:181:4: C0415: Import outside toplevel (taucmdr.cf.compiler.shmem.SHMEM_CC, taucmdr.cf.compiler.shmem.SHMEM_CXX, taucmdr.cf.compiler.shmem.SHMEM_FC) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:182:4: C0415: Import outside toplevel (taucmdr.cf.compiler.cuda.CUDA_CXX, taucmdr.cf.compiler.cuda.CUDA_FC) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:183:4: C0415: Import outside toplevel (taucmdr.cf.compiler.caf.CAF_FC) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:184:4: C0415: Import outside toplevel (taucmdr.cf.compiler.python.PY) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:551:8: C0415: Import outside toplevel (taucmdr.error.ImmutableRecordError) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:552:8: C0415: Import outside toplevel (taucmdr.model.experiment.Experiment) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:581:8: C0415: Import outside toplevel (taucmdr.error.ImmutableRecordError) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:582:8: C0415: Import outside toplevel (taucmdr.model.experiment.Experiment) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:596:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:615:8: C0415: Import outside toplevel (taucmdr.model.project.Project) (import-outside-toplevel)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/model/target.py:748:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
************* Module taucmdr.cf.software.tau_installation
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:436:0: C0301: Line too long (136/120) (line-too-long)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:438:0: C0301: Line too long (122/120) (line-too-long)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:464:0: C0301: Line too long (124/120) (line-too-long)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:486:0: C0301: Line too long (123/120) (line-too-long)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:509:0: C0301: Line too long (134/120) (line-too-long)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:516:0: C0301: Line too long (134/120) (line-too-long)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:439:46: C1802: Do not use `len(SEQUENCE)` without comparison to determine if a sequence is empty (use-implicit-booleaness-not-len)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:463:15: C3001: Lambda expression assigned to a variable. Define a function using the "def" keyword instead. (unnecessary-lambda-assignment)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:550:39: R1719: The if expression can be replaced with 'bool(test)' (simplifiable-if-expression)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:579:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:851:16: C0103: Variable name "g" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:855:20: C0103: Variable name "g" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:949:8: W1201: Use lazy % formatting in logging functions (logging-not-lazy)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:953:4: C0116: Missing function or method docstring (missing-function-docstring)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:1022:20: W1203: Use lazy % formatting in logging functions (logging-fstring-interpolation)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:1025:27: W0703: Catching too general exception Exception (broad-except)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:1030:31: R1729: Use a generator instead 'all(os.path.exists(path[1]) for path in err.args[0])' (use-a-generator)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:980:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:1234:21: C3001: Lambda expression assigned to a variable. Define a function using the "def" keyword instead. (unnecessary-lambda-assignment)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:1239:15: R1717: Consider using a dictionary comprehension (consider-using-dict-comprehension)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:1241:4: W0237: Parameter 'opts' has been renamed to 'compiler' in overridden 'TauInstallation.compiletime_config' method (arguments-renamed)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:1241:4: W0237: Parameter 'env' has been renamed to 'opts' in overridden 'TauInstallation.compiletime_config' method (arguments-renamed)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:1513:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:1513:45: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:1770:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:1919:4: C0116: Missing function or method docstring (missing-function-docstring)
/home/runner/work/taucmdr/taucmdr/packages/taucmdr/cf/software/tau_installation.py:167:0: R0904: Too many public methods (27/25) (too-many-public-methods)

Stderr

nchaimov

LGTM to me as well. All the tests are passing, so I'd say this is ready to merge.

zbeekman · 2022-06-30T19:13:57Z

Thanks so much @vikram8128

vikram8128 added 7 commits June 13, 2022 17:07

Added support for nvhpc compilers

f5814c5

Fixed linker issues with libelf and papi when compiled with nvhpc com…

9173cd4

…pilers.

Small edit missing from previous commit

784f4c7

Fixed issue with unique keys being used in InstalledCompilerSet

64f51a9

Added openacc support

fe9a6cf

Fixed issue with libelf installation

504accf

Libelf installation bug fix

565f248

vikram8128 requested a review from nchaimov June 28, 2022 01:44

nchaimov requested a review from zbeekman June 28, 2022 01:45

nchaimov reviewed Jun 28, 2022

View reviewed changes

packages/taucmdr/cf/software/tau_installation.py Outdated Show resolved Hide resolved

packages/taucmdr/model/target.py Show resolved Hide resolved

packages/taucmdr/cli/commands/trial/tests/test_create.py Outdated Show resolved Hide resolved

zbeekman requested changes Jun 28, 2022

View reviewed changes

Made review changes

e6033e4

nchaimov requested review from nchaimov and zbeekman June 28, 2022 23:40

nchaimov requested changes Jun 29, 2022

View reviewed changes

packages/taucmdr/cf/software/libelf_installation.py Outdated Show resolved Hide resolved

packages/taucmdr/cli/commands/trial/tests/test_create.py Show resolved Hide resolved

zbeekman requested changes Jun 29, 2022

View reviewed changes

Added environment argument to autotools configure

4142c1e

Neated up testing skip cases

nchaimov requested changes Jun 29, 2022

View reviewed changes

packages/taucmdr/cf/software/installation.py Outdated Show resolved Hide resolved

Fixed autotools configure

97ee48c

nchaimov self-requested a review June 29, 2022 21:15

nchaimov approved these changes Jun 29, 2022

View reviewed changes

nchaimov requested a review from zbeekman June 29, 2022 21:17

zbeekman approved these changes Jun 30, 2022

View reviewed changes

packages/taucmdr/cf/software/libelf_installation.py Outdated Show resolved Hide resolved

Style improvement to libelf_installation.py

72ead21

Co-authored-by: Izaak "Zaak" Beekman <zbeekman@gmail.com>

zbeekman approved these changes Jun 30, 2022

View reviewed changes

nchaimov approved these changes Jun 30, 2022

View reviewed changes

zbeekman merged commit 72ead21 into unstable Jun 30, 2022

zbeekman deleted the openacc branch June 30, 2022 19:13

This was referenced Jun 30, 2022

Add support for OpenACC #414

Closed

Support NVIDIA HPC SDK compilers #386

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for OpenACC #416

Added support for OpenACC #416

vikram8128 commented Jun 28, 2022

codecov bot commented Jun 28, 2022 •

edited

Loading

zbeekman left a comment

nchaimov left a comment

zbeekman left a comment

zbeekman left a comment

github-actions bot commented Jun 30, 2022

nchaimov left a comment

zbeekman commented Jun 30, 2022

Added support for OpenACC #416

Added support for OpenACC #416

Conversation

vikram8128 commented Jun 28, 2022

codecov bot commented Jun 28, 2022 • edited Loading

Codecov Report

zbeekman left a comment

Choose a reason for hiding this comment

nchaimov left a comment

Choose a reason for hiding this comment

zbeekman left a comment

Choose a reason for hiding this comment

zbeekman left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 30, 2022

Pylint Output

Report

Statistics by type

Raw metrics

Duplication

Messages by category

Messages

nchaimov left a comment

Choose a reason for hiding this comment

zbeekman commented Jun 30, 2022

codecov bot commented Jun 28, 2022 •

edited

Loading