Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed command registration fails in 1.19.1+ #8255

Closed
mibby opened this issue Aug 7, 2022 · 4 comments
Closed

Delayed command registration fails in 1.19.1+ #8255

mibby opened this issue Aug 7, 2022 · 4 comments
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to. version: 1.19 Game version 1.19

Comments

@mibby
Copy link

mibby commented Aug 7, 2022

Expected behavior

Commands from WorldGuard to work as they use to in 1.19.

Observed/Actual behavior

Commands from WorldGuard do not work in 1.19.1+.

Steps/models to reproduce

  • Install WorldGuard & WorldEdit to Paper-113 plugin folder.
  • Set yourself as OP
  • Try to use commands from WorldGuard such as /god.
  • Command is unknown.

Plugin and Datapack List

WorldEdit dev 6234
WorldGuard dev 2204

https://builds.enginehub.org/

Paper version

Paper version git-Paper-113 (MC: 1.19.2)

Other

RE: EngineHub/WorldGuard#1943

@mibby mibby added status: needs triage type: bug Something doesn't work as it was intended to. labels Aug 7, 2022
@Machine-Maker
Copy link
Member

Machine-Maker commented Aug 7, 2022

This is just an initial guess, but this is probably because the CommandMap is no longer used for executing commands, the brigadier dispatcher is. And they are only synced when CraftServer#syncCommands() is called. which is once after plugin loading, and during a reload.

This change was made (purposefully, I think) by spigot for 1.19.1

@mibby
Copy link
Author

mibby commented Aug 7, 2022

@wizjany / @me4502 Ping for notice.

@A248
Copy link
Contributor

A248 commented Aug 7, 2022

I can confirm this bug with LibertyBans' command aliases. Command registration fails to have effect after the startup process.

Command unregistration also fails. Unregistering a command has no effect, either.

@lynxplay lynxplay added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. version: 1.19 Game version 1.19 and removed status: needs triage labels Aug 7, 2022
@lynxplay lynxplay moved this to accepted in Issues: Bugs Aug 7, 2022
@Owen1212055
Copy link
Member

Fixed by #8235

@github-project-automation github-project-automation bot moved this from ✅ Accepted to Done in Issues: Bugs May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to. version: 1.19 Game version 1.19
Projects
Status: Done
Development

No branches or pull requests

5 participants