Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update src/style/app.module.css to New Color Scheme #2880

Closed
palisadoes opened this issue Dec 26, 2024 · 11 comments
Closed

Update src/style/app.module.css to New Color Scheme #2880

palisadoes opened this issue Dec 26, 2024 · 11 comments
Assignees
Labels
bug Something isn't working unapproved

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 26, 2024

Describe the bug

We have recently changed the color scheme to be more compatible with the needs of the color blind. This means that we have eliminated the green colors from the app.

The recent work to consolidate our CSS into the singe src/style/app.module.css file has allowed some green colors to slip through

To Reproduce
These green colors are present in the CSS. They need to be replaced with the pre-existing blue / grey tones used in other elements with similar purpose.

Expected behavior

  • Replace green tones with the pre-existing blue / grey tones used in other elements with similar purpose.

Actual behavior

  • See above

Screenshots

  1. Color #31bb6b
    image
  2. Color #afffe8
    image

Additional details

  • N/A

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added the bug Something isn't working label Dec 26, 2024
@palisadoes palisadoes changed the title Update CSS File to New Color Scheme Update src/style/app.module.css to New Color Scheme Dec 26, 2024
@rahulch07
Copy link
Contributor

Please assign me this

@palisadoes
Copy link
Contributor Author

Please note that we are using much more muted tones as the replacement color. Use the appropriate replacement. If I'm doubt ask @AVtheking

@rahulch07
Copy link
Contributor

Please note that we are using much more muted tones as the replacement color. Use the appropriate replacement. If I'm doubt ask @AVtheking

Okay👍

@rahulch07
Copy link
Contributor

@AVtheking any suggestion for color of disabled buttons. Did not found any disable button in other components to take reference . Is this ok? Or any other color?
WhatsApp Image 2024-12-31 at 12 16 46 AM

image

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 10, 2025
@rahulch07
Copy link
Contributor

working on it...

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@rahulch07
Copy link
Contributor

@palisadoes

  1. Greens in SuperAdmin, Admin, User have been replaced with their respective blue/grey tones.
  2. Introduced a CSS methodology and merged to talawa-docs

What's next?

Should we plan to get these changes to develop branch?

Also have observed that in app.module.css there are many redundant/repetative classes. I think after all CSS components are refactored to app.module.css these issue should be addressed.

Let me know if there's anything else I can take on.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jan 26, 2025
@palisadoes
Copy link
Contributor Author

  1. Implementing Dark Mode as the new CSS file is almost complete
  2. Please create an issue for that and ask to be assigned

@rahulch07
Copy link
Contributor

Yes

@rahulch07
Copy link
Contributor

@palisadoes should this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unapproved
Projects
None yet
Development

No branches or pull requests

2 participants