Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiate Transforms Using Hydra #524

Closed
Pale-Blue-Dot-97 opened this issue Aug 19, 2024 · 0 comments · Fixed by #535
Closed

Instantiate Transforms Using Hydra #524

Pale-Blue-Dot-97 opened this issue Aug 19, 2024 · 0 comments · Fixed by #535
Assignees
Labels
boilerplate Code is repetitive enhancement New feature or request generalise Code needs generalising
Milestone

Comments

@Pale-Blue-Dot-97
Copy link
Owner

Is your feature request related to a problem? Please describe.
Transforms are currently defined via the config but are not instantiated using hydra. This results in a clunky YAML syntax and various conditionals so a user can outline the program of transforms they want. There are also somethings that are not currently possible, such as passing args to transforms that are not primitive types.

Describe the solution you'd like
Use hydra.utils,instantiate to build the transforms. This can handle nested instantiates (superseeding some of the currently minerva defined functionality` as well as opening up new functionality.

Describe alternatives you've considered
Continue to add new conditionals and adaptions of existing transforms for new use cases as and when required.

Additional context
Other elements of the config already support hydra.utils.instantiate such as the optimiser or loss function. Making this change will continue the move towards consistency and better UX across minerva.

@Pale-Blue-Dot-97 Pale-Blue-Dot-97 added enhancement New feature or request generalise Code needs generalising boilerplate Code is repetitive labels Aug 19, 2024
@Pale-Blue-Dot-97 Pale-Blue-Dot-97 self-assigned this Aug 19, 2024
@Pale-Blue-Dot-97 Pale-Blue-Dot-97 added this to the v0.28 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boilerplate Code is repetitive enhancement New feature or request generalise Code needs generalising
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant