Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.12 #424

Closed
Pale-Blue-Dot-97 opened this issue Jan 23, 2024 · 2 comments · Fixed by #535
Closed

Support Python 3.12 #424

Pale-Blue-Dot-97 opened this issue Jan 23, 2024 · 2 comments · Fixed by #535
Assignees
@Pale-Blue-Dot-97
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request python Pull requests that update Python code

Comments

@Pale-Blue-Dot-97
Copy link
Owner

Is your feature request related to a problem? Please describe.
Python 3.12 has been out of beta for several months yet minerva still doesn't support it.

Describe the solution you'd like
Add official support for Python 3.12 by adjusting the requirements and adding 3.12 workflows for CI/CD.

Describe alternatives you've considered
Not supporting Python 3.12 and sticking with 3.11 as the most up-to-date Python supported.

Additional context
Currently blocked by onnx having a Python 3.12 wheel.
@Pale-Blue-Dot-97 Pale-Blue-Dot-97 added bug Something isn't working enhancement New feature or request dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 23, 2024
@Pale-Blue-Dot-97 Pale-Blue-Dot-97 self-assigned this Jan 23, 2024
@Pale-Blue-Dot-97
Copy link
Owner Author

Blocker is now tensorflow. Latest stable build does not support Python 3,12. Using latest tf-nightly as shown in a3597ce does not rectify this.

@Pale-Blue-Dot-97
Copy link
Owner Author

tensorflow has been updated and onnx has a onnx-weekly version that supports 3.12. The only blocker now is onnx2torch which will only use onnx not onnx-weekly. Also, torch.compile is still unsupported in 3,12 so has to be bypassed.

This was referenced Jul 10, 2024
Merged
Merged
@Pale-Blue-Dot-97 Pale-Blue-Dot-97 mentioned this issue Sep 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pale-Blue-Dot-97 Pale-Blue-Dot-97

Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minerva v0.28.0 Pale-Blue-Dot-97/Minerva
1 participant
@Pale-Blue-Dot-97