Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time zone validation is not aligned with the API #796

Closed
drastawi opened this issue Jan 5, 2024 · 1 comment · Fixed by #826
Closed

Time zone validation is not aligned with the API #796

drastawi opened this issue Jan 5, 2024 · 1 comment · Fixed by #826

Comments

@drastawi
Copy link
Contributor

drastawi commented Jan 5, 2024

The time zone validation that was introduced in #473 does not seem to be compatible with what is present on the API, for example US/Mountain is valid in the provider checks but it fails on the API. Likely the solution is to align the version of the tz info between the provider and the API.

Terraform Version

1.6.6

Affected Resource(s)

  • user
  • service
  • service event rule
  • schedule
  • ruleset rule

Terraform Configuration Files

timezone = "US/Mountain"

Debug Output

Panic Output

time zone is not a valid tzinfo identifier

Expected Behavior

Should throw an error

Actual Behavior

Calls the API

Steps to Reproduce

  1. terraform apply

References

https://stackoverflow.com/questions/64619841/time-loadlocation-gives-unknown-timezone-for-us-pacific-new-timezone

@drastawi
Copy link
Contributor Author

drastawi commented Feb 9, 2024

In response to this the PagerDuty team posted the list of valid timezones on the API side. https://developer.pagerduty.com/docs/1afe25e9c94cb-types#time-zone
To fix the validation we'd have to hard-code them into the provider code. @imjaroiswebdev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant