Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't re-create services if support hours or scheduled actions change #68

Merged
merged 4 commits into from
Apr 10, 2018
Merged

Don't re-create services if support hours or scheduled actions change #68

merged 4 commits into from
Apr 10, 2018

Conversation

mbelekar
Copy link
Contributor

@mbelekar mbelekar commented Feb 22, 2018 •
edited
Loading

We have added a fix so that services don't get recreated when we change scheduled action or support hours. Fixes #53

Acceptance tests results :

➜  terraform-provider-pagerduty git:(service-recreate) ✗ TF_ACC=1 go test github.com/terraform-providers/terraform-provider-pagerduty/pagerduty -v -run=TestAccPagerDutyService_SupportHoursChange -timeout 120m
=== RUN   TestAccPagerDutyService_SupportHoursChange
--- PASS: TestAccPagerDutyService_SupportHoursChange (19.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	19.441s

@mbelekar mbelekar mentioned this pull request Feb 22, 2018
Closed
Manasi Belekar added 2 commits February 22, 2018 18:07
@mbelekar
Copy link
Contributor Author

Could we have some 👀 on this one please?

@heimweh heimweh self-requested a review April 10, 2018 20:28
heimweh
heimweh approved these changes Apr 10, 2018
View reviewed changes
Copy link
Collaborator

@heimweh heimweh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mbelekar,

thank you so much for this contribution.
Confirmed working. This LGTM 👍

@heimweh heimweh merged commit 9da599a into PagerDuty:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heimweh heimweh heimweh approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing a PagerDuty service's support hours or scheduled actions recreates the service
3 participants
@mbelekar @heimweh @vancluever