Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many unnecessarily long timeouts on known errors #544

Closed
drastawi opened this issue Jul 14, 2022 · 0 comments · Fixed by #713
Closed

Too many unnecessarily long timeouts on known errors #544

drastawi opened this issue Jul 14, 2022 · 0 comments · Fixed by #713

Comments

@drastawi
Copy link
Contributor

drastawi commented Jul 14, 2022

As a result of #454 running terraform on a project with an error in the config or one that contains a resource that had been manually deleted became extremely slow. The rules for retry are not centralized and vary widely from resource type to resource type.

There is a lot of value in retrying for a long time on 429 but for example, we should not wait 5 min to learn we made a typo or are missing field and get a 400. Sometimes it might be valuable to avoid a race condition for a 404, but that should not take 5min, maybe 30s.

@drastawi drastawi changed the title Introduce more response code checking and centralize logic for error timeouts duration Too many unnecessarily long timeouts on known errors Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant