Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating service_dependency to support technical service dependencies #238

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Updating service_dependency to support technical service dependencies #238

merged 2 commits into from
Jun 4, 2020

Conversation

stmcallister
Copy link
Contributor

Added support for technical service dependencies as well as tests for that feature. Also updated the docs. This addresses #226

Test results

TF_ACC=1 go test -run "TestAccPagerDutyBusinessServiceDependency_Basic" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyBusinessServiceDependency_Basic
--- PASS: TestAccPagerDutyBusinessServiceDependency_Basic (12.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	12.994s

TF_ACC=1 go test -run "TestAccPagerDutyTechnicalServiceDependency_Basic" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyTechnicalServiceDependency_Basic
--- PASS: TestAccPagerDutyTechnicalServiceDependency_Basic (11.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	12.172s

heimweh
heimweh approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@heimweh heimweh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌

@stmcallister stmcallister merged commit 6fac4aa into PagerDuty:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heimweh heimweh heimweh approved these changes

Assignees
No one assigned
Labels
dependencies documentation size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stmcallister @heimweh