resource_pagerduty_service_integration: Fix panic #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the service integration cannot be found we must return early, this is to prevent running into a panic when trying to dereference further down when setting the state. We also mark the "service" attribute with ForceNew since we don't have a way of migrating service integrations to another service. This means that service integrations will be destroyed and re-created. This fixes the current behavior where Terraform would just return an error, forcing the user to run Terraform again so that the new service integration can be created. This fixes it all in one go by destroying the previous service integration from the old service and adding it to the new service without having to run it two times. Note: This only happens if the "service" attribute changes. This won't affect already existing integrations.
ghost
added
the
stmcallister
approved these changes
Apr 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204
If the service integration cannot be found we must return early, this is
to prevent running into a panic when trying to dereference further down
when setting the state.
We also mark the "service" attribute with ForceNew since we don't have a
way of migrating service integrations to another service. This means
that service integrations will be destroyed and re-created. This fixes
the current behavior where Terraform would just return an error, forcing
the user to run Terraform again so that the new service integration can
be created. This fixes it all in one go by destroying the previous
service integration from the old service and adding it to the new
service without having to run it two times. Note: This only happens if
the "service" attribute changes.