Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Ruleset_Rule Import of Catch All Rules #205

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Fixing Ruleset_Rule Import of Catch All Rules #205

merged 2 commits into from
Apr 15, 2020

Conversation

stmcallister
Copy link
Contributor

@stmcallister stmcallister commented Apr 15, 2020 •
edited
Loading

Addresses issue #197

TF_ACC=1 go test -run "TestAccPagerDutyRulesetRule_Basic" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyRulesetRule_Basic
--- PASS: TestAccPagerDutyRulesetRule_Basic (7.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	8.230s
terraform-provider-pagerduty $ TF_ACC=1 go test -run "TestAccPagerDutyRulesetRule_import" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyRulesetRule_import
--- PASS: TestAccPagerDutyRulesetRule_import (5.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	5.572s

@ghost ghost added the size/XS label Apr 15, 2020
@heimweh heimweh merged commit 4adc2c8 into PagerDuty:master Apr 15, 2020
@jhon287
Copy link

jhon287 commented May 7, 2020

@stmcallister that's great that we can import catch_all rules... But how do we managed catch_all rules that has been automatically created using pagerduty_ruleset? Do we have to import them manually?

@jhon287 jhon287 mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heimweh heimweh heimweh approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stmcallister @jhon287 @heimweh