Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Ruleset and Ruleset Rule Resources #195

Merged
merged 9 commits into from
Apr 7, 2020
Merged

Adding Ruleset and Ruleset Rule Resources #195

merged 9 commits into from
Apr 7, 2020

Conversation

stmcallister
Copy link
Contributor

This adds resources for pagerduty_ruleset and pagerduty_ruleset_rule. This relates to issue #176 .

Test results:

TF_ACC=1 go test -run "TestAccPagerDutyRulesetRule_Basic" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyRulesetRule_Basic
--- PASS: TestAccPagerDutyRulesetRule_Basic (10.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	13.367s


TF_ACC=1 go test -run "TestAccPagerDutyRuleset_Basic" ./pagerduty -v -timeout 120m 
=== RUN   TestAccPagerDutyRuleset_Basic
--- PASS: TestAccPagerDutyRuleset_Basic (8.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	9.400s

@ghost ghost added the dependencies label Apr 6, 2020
heimweh
heimweh approved these changes Apr 6, 2020
View reviewed changes
Copy link
Collaborator

@heimweh heimweh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 👌

This LGTM 👍

@stmcallister stmcallister merged commit 449d165 into PagerDuty:master Apr 7, 2020
@jhon287 jhon287 mentioned this pull request Apr 8, 2020
Closed
jhon287
jhon287 reviewed Apr 8, 2020
View reviewed changes
website/docs/r/ruleset_rule.html.markdown
Ruleset rules can be imported using the `id`, e.g.

```
$ terraform import pagerduty_ruleset_rule.main 19acac92-027a-4ea0-b06c-bbf516519601
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stmcallister This seems not working... See issue https://github.com/terraform-providers/terraform-provider-pagerduty/issues/197

jhon287
jhon287 reviewed Apr 9, 2020
View reviewed changes
vendor/github.com/heimweh/go-pagerduty/pagerduty/business_service.go

// BusinessServiceService handles the communication with business service
// related methods of the PagerDuty API.
type BusinessServiceService service
Copy link

@jhon287 jhon287 Apr 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stmcallister Is it to prepare Business service Terraform PagerDuty resource ?
Do you know if it will be available soon ?

@jhon287 jhon287 mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhon287 jhon287 jhon287 left review comments

@heimweh heimweh heimweh approved these changes

Assignees
No one assigned
Labels
dependencies documentation size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stmcallister @jhon287 @heimweh