Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing pagerduty_event_rule.catch_all field to Computed #169

Merged
merged 4 commits into from
Dec 6, 2019

Conversation

stmcallister
Copy link
Contributor

PagerDuty API doesn't allow for catch_all to be set through the API. This PR makes that field Computed so that the provider doesn't try to manipulate its value. This is in response to issue 167

Test results

TF_ACC=1 go test -run "TestAccPagerDutyEventRule_Basic" ./pagerduty -v -timeout 120m

=== RUN   TestAccPagerDutyEventRule_Basic
--- PASS: TestAccPagerDutyEventRule_Basic (9.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	10.533s

TF_ACC=1 go test -run "TestAccPagerDutyEventRule_import" ./pagerduty -v -timeout 120m

=== RUN   TestAccPagerDutyEventRule_import
--- PASS: TestAccPagerDutyEventRule_import (5.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	5.787s

Copy link
Collaborator

@heimweh heimweh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This LGTM 👌

@heimweh heimweh merged commit cc9b550 into PagerDuty:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants