Injecting the name search explicitly into the Team search #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
heimweh
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
Hi @oldNoakes,
thank you so much for this contribution!
This both makes sense and looks good to me 👍
Tests are passing as well so I'll go ahead and merge this.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running into an issue similar to issue https://github.com/terraform-providers/terraform-provider-pagerduty/issues/105 which seems to be related (in my case at least) to the 25 team limit in the pagerduty search.
We could increase the search limit to an arbitrary large number but seeing as we need to provide the name for the search anyway and the query can use this, this seems like the simplest solution.