Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update initialisms / acronyms to be capitalized #268

Closed
theckman opened this issue Feb 8, 2021 · 1 comment · Fixed by #332
Closed

Update initialisms / acronyms to be capitalized #268

theckman opened this issue Feb 8, 2021 · 1 comment · Fixed by #332
Milestone

Comments

@theckman
Copy link
Collaborator

theckman commented Feb 8, 2021

There are some names in the packages that are either initialisms or acronyms, and they are not capitalized. That is the common style, and is called out in the Go wiki, and so it seems good to enforce it here.

This will definitely be a breaking change, and so we should wait to do that until v2.0.0.

Example:

Id string `json:"id,omitempty"`

@theckman theckman added this to the v2.0.0 milestone Feb 8, 2021
@theckman theckman modified the milestones: v2.0.0, v1.5.0 May 16, 2021
@theckman
Copy link
Collaborator Author

We need to remove this Id field anyhow because of the issue reported in #218, and so we are going to move this into v1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant