Add some pre-commit check items. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wangkuiyi Please help to authorize the repo for CI. |
kuke
reviewed
Apr 7, 2018
| import platform | ||
|
|
||
| COPYRIGHT = ''' | ||
| Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserved. |
There was a problem hiding this comment.
@kuke Seems cpp code is necessary, @varunarora please help to confirm it.
There was a problem hiding this comment.
@kuke 2016 is only a place-holder, actual year is generated dynamically:
Line 39
process = subprocess.Popen(["date", "+%Y"], stdout=subprocess.PIPE)
There was a problem hiding this comment.
clang-format removed.
There was a problem hiding this comment.
Great - yes this is exactly it needs to be dynamically replaced
|
I merged this PR to test CI. If necessary, we can revert it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7