Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure protoc installed. #15

Merged
merged 4 commits into from
Apr 10, 2018
Merged

Make sure protoc installed. #15

merged 4 commits into from
Apr 10, 2018

Conversation

pkuyym
Copy link
Collaborator

@pkuyym pkuyym commented Apr 10, 2018 •
edited
Loading

Resolves #14

@pkuyym pkuyym requested a review from kuke April 10, 2018 08:01
kuke
kuke approved these changes Apr 10, 2018
View reviewed changes
Copy link

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkuyym pkuyym merged commit c3c6934 into PaddlePaddle:develop Apr 10, 2018
@varunarora
Copy link
Collaborator

Oh guys I intentionally had chosen ONNX 1.0. 1.1 has some issues on Mac due to protoc compatibility. Is it possible to reconsider this?

@kuke
Copy link

kuke commented Apr 12, 2018

Can you upgrade protoc? I found the 1.0 version is too older, so change to the latest one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuke kuke kuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkuyym @varunarora @kuke