-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to use the updated deepcopy generation program #584
Conversation
It is a little strange here that the CI passes but my local build doesn't:
|
|
And, develop branch is going on to CRD, if we want to build TPR version, we have to checkout the previous release tag. Only CRD need to generate DeepCopy codes. |
Does this mean that what this PR should do is to remove |
Yes, we can remove these files. |
Sorry, seems these two files can not be removed for now, because we have already updated the Kubernetes API dependency to 1.8, the resource defination must require generated DeepCopy file. I'll try to go over the code again tomorrow to fix this problem. |
As discussed under pr #565 , the problem of deepcopy generation will be solved ASAP. |
Thanks to @m3ngyang . I am closing this PR. |
Fix #585