rm ca.srl
#530
Closed
rm ca.srl
#530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yancey1989
reviewed
Dec 21, 2017
paddlecloud/notebook/tls.py
Outdated
| @@ -36,6 +36,7 @@ def create_user_cert(ca_path, username): | |||
| %s/%s.csr -subj \"/CN=%s\""%\ | |||
| (user_cert_dir, username, | |||
| user_cert_dir, username, username)) | |||
| user_cert_cmds.append("rm -f %s/ca.srl" % settings.USER_CERTS_PATH) | |||
There was a problem hiding this comment.
In my own curiosity, why delete this file, or could you add some comments here?
Yancey1989
reviewed
Dec 21, 2017
| @@ -36,6 +36,9 @@ def create_user_cert(ca_path, username): | |||
| %s/%s.csr -subj \"/CN=%s\""%\ | |||
| (user_cert_dir, username, | |||
| user_cert_dir, username, username)) | |||
| # FIXME(gongwb):why need delete ca.srl when mount afs path while not need | |||
There was a problem hiding this comment.
FIXME(gongwb): The file ca.srl containing a serial number will cause an error on the AFS (mount local path by VFS ), delete this file for temporary and make the code work!
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #531