Add "submit trainingjobs". #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongweibao
changed the title
gongweibao
changed the title
helinwang
reviewed
Dec 14, 2017
go/paddlectl/submit.go
Outdated
| return err | ||
| } | ||
|
|
||
| if err := putFilesToPfs(jobPackage, jobName); err != nil { | ||
| var respObj interface{} |
There was a problem hiding this comment.
Maybe change to:
var respObj map[string]string
| @@ -7,42 +14,21 @@ def get_trainingjob(paddlejob): | |||
| }, | |||
| "spec": { | |||
| "image": paddlejob.image, | |||
| "port": paddlejob.port, | |||
| "ports_num_for_sparse": paddlejob.ports_num_for_sparse, | |||
| #"port": paddlejob.port, | |||
There was a problem hiding this comment.
No commented out code please :)
typhoonzero
requested changes
Dec 15, 2017
|
用户配额信息、权限信息在PaddleCloud的。貌似他是不能被绕过的。 @typhoonzero |
|
@gongweibao 和 @Yancey1989 沟通，明白了的确需要把用户相关的信息和配置放在python端，使 |
typhoonzero
previously approved these changes
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #462.