Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split backend and paddlejob abstraction #374

Merged
merged 6 commits into from
Sep 25, 2017

Conversation

typhoonzero
Copy link
Collaborator

Fix #373

After this PR we can put more backends to it to support more clusters like kubernetes.

Copy link
Collaborator

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes/minikube
我们需要一个单测系统,特别是多个后端的情况下。

import utils
import volume

# FIXME(typhoonzero): need a base class to define the interfaces?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果是想抽象多个后端的接口,Interface层还是需要的。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所以目前是FIXME,后续增加即可。目前没必要嵌套那么多层。

from kubernetes import client, config
from kubernetes.client.rest import ApiException
# FIXME(typhoonzero): still need to import settings
from django.conf import settings
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不利于单测

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所以加了FIXME,目前只能把配置都放一个settings里,分成多个配置文件,会让部署很麻烦。

另外即使要加单测,from django.conf import settings也是有方法可以使用的。

Copy link
Collaborator

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typhoonzero typhoonzero merged commit ec0fac1 into PaddlePaddle:develop Sep 25, 2017
@typhoonzero typhoonzero deleted the split_backend branch November 2, 2017 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants