Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Chinese charaset error #240

Merged
merged 8 commits into from
Jul 24, 2017
Merged

Fix Chinese charaset error #240

merged 8 commits into from
Jul 24, 2017

Conversation

gongweibao
Copy link
Collaborator

@gongweibao gongweibao commented Jul 24, 2017 •
edited
Loading

Fix #230

typhoonzero
typhoonzero reviewed Jul 24, 2017
View reviewed changes
k8s/mysql/paddlecloud.sql Outdated
@@ -0,0 +1 @@
CREATE DATABASE IF NOT EXISTS paddlecloud DEFAULT CHARACTER SET utf8 DEFAULT COLLATE utf8_general_ci;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put this in the kubernetes yaml file as "command" instead of using a self image repo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

typhoonzero
typhoonzero previously approved these changes Jul 24, 2017
View reviewed changes
Copy link
Collaborator

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

typhoonzero
typhoonzero approved these changes Jul 24, 2017
View reviewed changes
Copy link
Collaborator

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@gongweibao gongweibao merged commit f10c6a6 into PaddlePaddle:develop Jul 24, 2017
@gongweibao gongweibao deleted the charset branch July 24, 2017 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

@Yancey1989 Yancey1989 Awaiting requested review from Yancey1989

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gongweibao @typhoonzero