-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support registry resource #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add docs in doc/usage_cn.md
subcommands.Register(&pfsmod.MkdirCmd{}, "") | ||
subcommands.Register(&paddlecloud.RegistryCmd{}, "") | ||
subcommands.Register(&paddlecloud.DeleteCommand{}, "") | ||
subcommands.Register(&pfsmod.LsCmd{}, "PFS") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the second argument "PFS"
mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second argument of subcommands.Register
is group, if we add a subcommand with a specify a group name, these subcommands will be explained with a group name before, such as:
Subcommands:
commands list all command names
delete Delete the specify resource.
file Simple file operations.
...
Subcommands for PFS:
cp uoload or download files
ls List files on PaddlePaddle Cloud
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Still, commands like paddlecloud registry ...
means add, but there's no verb in this command
paddlecloud registry --name test --username test --password test --server x.y.z
paddlecloud delete registry ${registry-name}
paddlecloud get registry
Fixed #140