From 22f49bb80ab712e6acd0f28bfc2cc383e7d41197 Mon Sep 17 00:00:00 2001 From: yllhwa Date: Thu, 30 Mar 2023 09:36:17 +0800 Subject: [PATCH 1/2] [CodeStyle][PLR0402]use from {} import {} --- .../tests/unittests/collective/collective_allreduce_api.py | 6 +++--- .../tests/unittests/collective/collective_reduce_api.py | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/python/paddle/fluid/tests/unittests/collective/collective_allreduce_api.py b/python/paddle/fluid/tests/unittests/collective/collective_allreduce_api.py index 30a0f951b7bfea..8929618fa7f197 100644 --- a/python/paddle/fluid/tests/unittests/collective/collective_allreduce_api.py +++ b/python/paddle/fluid/tests/unittests/collective/collective_allreduce_api.py @@ -16,9 +16,9 @@ import paddle import paddle.distributed as dist -import paddle.fluid as fluid -import paddle.fluid.data_feeder as data_feeder -import paddle.framework as framework +from paddle import fluid +from paddle.fluid import data_feeder +from paddle import framework paddle.enable_static() diff --git a/python/paddle/fluid/tests/unittests/collective/collective_reduce_api.py b/python/paddle/fluid/tests/unittests/collective/collective_reduce_api.py index 50da61bfcb02b8..0243323ffdc82f 100644 --- a/python/paddle/fluid/tests/unittests/collective/collective_reduce_api.py +++ b/python/paddle/fluid/tests/unittests/collective/collective_reduce_api.py @@ -16,9 +16,9 @@ import paddle import paddle.distributed as dist -import paddle.fluid as fluid -import paddle.fluid.data_feeder as data_feeder -import paddle.framework as framework +from paddle import fluid +from paddle.fluid import data_feeder +from paddle import framework paddle.enable_static() From 5ce03878c161a100cdae4185ef8362f73acbc27b Mon Sep 17 00:00:00 2001 From: yllhwa Date: Thu, 30 Mar 2023 09:38:56 +0800 Subject: [PATCH 2/2] [CodeStyle][C405]Unnecessary {obj_type} literal --- .../unittests/test_conv2d_op_depthwise_conv.py | 12 ++++++------ .../tests/unittests/test_conv2d_transpose_op.py | 16 ++++++++-------- .../fluid/tests/unittests/test_kldiv_loss_op.py | 2 +- .../fluid/tests/unittests/test_kthvalue_op.py | 4 ++-- .../paddle/fluid/tests/unittests/test_mode_op.py | 4 ++-- .../tests/unittests/test_smooth_l1_loss_op.py | 4 ++-- 6 files changed, 21 insertions(+), 21 deletions(-) diff --git a/python/paddle/fluid/tests/unittests/test_conv2d_op_depthwise_conv.py b/python/paddle/fluid/tests/unittests/test_conv2d_op_depthwise_conv.py index 3532e090fe8c04..252eff92991563 100644 --- a/python/paddle/fluid/tests/unittests/test_conv2d_op_depthwise_conv.py +++ b/python/paddle/fluid/tests/unittests/test_conv2d_op_depthwise_conv.py @@ -416,14 +416,14 @@ def test_check_grad_no_filter(self): place = core.CUDAPlace(0) if core.is_float16_supported(place) and grad_check: self.check_grad_with_place( - place, ['Input'], 'Output', no_grad_set=set(['Filter']) + place, ['Input'], 'Output', no_grad_set={'Filter'} ) def test_check_grad_no_input(self): place = core.CUDAPlace(0) if core.is_float16_supported(place) and grad_check: self.check_grad_with_place( - place, ['Filter'], 'Output', no_grad_set=set(['Input']) + place, ['Filter'], 'Output', no_grad_set={'Input'} ) cls_name = "{0}_{1}".format(parent.__name__, "FP16OP") @@ -464,7 +464,7 @@ def test_check_grad_no_filter(self): place, ['Input'], 'Output', - no_grad_set=set(['Filter']), + no_grad_set={'Filter'}, user_defined_grads=[numeric_grads], ) @@ -475,7 +475,7 @@ def test_check_grad_no_input(self): place, ['Filter'], 'Output', - no_grad_set=set(['Input']), + no_grad_set={'Input'}, user_defined_grads=[numeric_grads], ) @@ -503,14 +503,14 @@ def test_check_grad_no_filter(self): place = core.CUDAPlace(0) if core.is_float16_supported(place) and grad_check: self.check_grad_with_place( - place, ['Input'], 'Output', no_grad_set=set(['Filter']) + place, ['Input'], 'Output', no_grad_set={'Filter'} ) def test_check_grad_no_input(self): place = core.CUDAPlace(0) if core.is_float16_supported(place) and grad_check: self.check_grad_with_place( - place, ['Filter'], 'Output', no_grad_set=set(['Input']) + place, ['Filter'], 'Output', no_grad_set={'Input'} ) def init_data_format(self): diff --git a/python/paddle/fluid/tests/unittests/test_conv2d_transpose_op.py b/python/paddle/fluid/tests/unittests/test_conv2d_transpose_op.py index ee413679fb1b9e..d1829d606570eb 100644 --- a/python/paddle/fluid/tests/unittests/test_conv2d_transpose_op.py +++ b/python/paddle/fluid/tests/unittests/test_conv2d_transpose_op.py @@ -796,11 +796,11 @@ def test_check_grad_no_input(self): ['Filter'], 'Output', max_relative_error=0.02, - no_grad_set=set(['Input']), + no_grad_set={'Input'}, ) else: self.check_grad( - ['Filter'], 'Output', no_grad_set=set(['Input']) + ['Filter'], 'Output', no_grad_set={'Input'} ) def test_check_grad_no_filter(self): @@ -813,11 +813,11 @@ def test_check_grad_no_filter(self): ['Input'], 'Output', max_relative_error=0.02, - no_grad_set=set(['Filter']), + no_grad_set={'Filter'}, ) else: self.check_grad( - ['Input'], 'Output', no_grad_set=set(['Filter']) + ['Input'], 'Output', no_grad_set={'Filter'} ) def test_check_grad(self): @@ -827,13 +827,13 @@ def test_check_grad(self): if core.is_float16_supported(place): self.check_grad_with_place( place, - set(['Input', 'Filter']), + {'Input', 'Filter'}, 'Output', max_relative_error=0.02, ) else: self.check_grad( - set(['Input', 'Filter']), 'Output', max_relative_error=0.02 + {'Input', 'Filter'}, 'Output', max_relative_error=0.02 ) @@ -980,7 +980,7 @@ def test_check_grad_no_input(self): ['Filter'], 'Output', max_relative_error=0.02, - no_grad_set=set(['Input']), + no_grad_set={'Input'}, user_defined_grads=[numeric_grads], ) @@ -992,7 +992,7 @@ def test_check_grad_no_filter(self): ['Input'], 'Output', max_relative_error=0.02, - no_grad_set=set(['Filter']), + no_grad_set={'Filter'}, user_defined_grads=[numeric_grads], ) diff --git a/python/paddle/fluid/tests/unittests/test_kldiv_loss_op.py b/python/paddle/fluid/tests/unittests/test_kldiv_loss_op.py index ea2b8ea405e434..819f506a40f9a9 100644 --- a/python/paddle/fluid/tests/unittests/test_kldiv_loss_op.py +++ b/python/paddle/fluid/tests/unittests/test_kldiv_loss_op.py @@ -58,7 +58,7 @@ def test_check_output(self): self.check_output() def test_check_grad(self): - self.check_grad(['X'], 'Loss', no_grad_set=set(["Target"])) + self.check_grad(['X'], 'Loss', no_grad_set={"Target"}) def initTestCase(self): self.x_shape = (4, 5, 5) diff --git a/python/paddle/fluid/tests/unittests/test_kthvalue_op.py b/python/paddle/fluid/tests/unittests/test_kthvalue_op.py index 46f6b7ef013520..b757974126cbb2 100644 --- a/python/paddle/fluid/tests/unittests/test_kthvalue_op.py +++ b/python/paddle/fluid/tests/unittests/test_kthvalue_op.py @@ -58,7 +58,7 @@ def test_check_output(self): def test_check_grad(self): paddle.enable_static() - self.check_grad(set(['X']), 'Out') + self.check_grad({'X'}, 'Out') class TestKthvalueOpWithKeepdim(OpTest): @@ -85,7 +85,7 @@ def test_check_output(self): def test_check_grad(self): paddle.enable_static() - self.check_grad(set(['X']), 'Out') + self.check_grad({'X'}, 'Out') class TestKthvalueOpKernels(unittest.TestCase): diff --git a/python/paddle/fluid/tests/unittests/test_mode_op.py b/python/paddle/fluid/tests/unittests/test_mode_op.py index 4f72389e542f00..eaf9c39631c970 100644 --- a/python/paddle/fluid/tests/unittests/test_mode_op.py +++ b/python/paddle/fluid/tests/unittests/test_mode_op.py @@ -78,7 +78,7 @@ def test_check_output(self): def test_check_grad(self): paddle.enable_static() - self.check_grad(set(['X']), 'Out') + self.check_grad({'X'}, 'Out') class TestModeOpLastdim(OpTest): @@ -103,7 +103,7 @@ def test_check_output(self): def test_check_grad(self): paddle.enable_static() - self.check_grad(set(['X']), 'Out') + self.check_grad({'X'}, 'Out') class TestModeOpKernels(unittest.TestCase): diff --git a/python/paddle/fluid/tests/unittests/test_smooth_l1_loss_op.py b/python/paddle/fluid/tests/unittests/test_smooth_l1_loss_op.py index e045e6f1eab63d..7c19db6d7b5c00 100644 --- a/python/paddle/fluid/tests/unittests/test_smooth_l1_loss_op.py +++ b/python/paddle/fluid/tests/unittests/test_smooth_l1_loss_op.py @@ -102,7 +102,7 @@ def test_check_grad_ingore_x(self): ['Y'], 'Out', max_relative_error=0.03, - no_grad_set=set(['X', 'InsideWeight', 'OutsideWeight']), + no_grad_set={'X', 'InsideWeight', 'OutsideWeight'}, ) def test_check_grad_ingore_y(self): @@ -110,7 +110,7 @@ def test_check_grad_ingore_y(self): ['X'], 'Out', max_relative_error=0.03, - no_grad_set=set(['Y', 'InsideWeight', 'OutsideWeight']), + no_grad_set={'Y', 'InsideWeight', 'OutsideWeight'}, )