Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'VarDesc' needs the support of holding multiple LoDTensorsDesc #8113

Closed
JiayiFeng opened this issue Feb 4, 2018 · 0 comments · Fixed by #8135
Closed

'VarDesc' needs the support of holding multiple LoDTensorsDesc #8113

JiayiFeng opened this issue Feb 4, 2018 · 0 comments · Fixed by #8135
Assignees

Comments

@JiayiFeng
Copy link
Collaborator

So far our VarDesc can only hold one LoDTensorDesc. Although a LoDTensorArray has more than one LoDTensor in the runtime, all the LoDTensors share the same shape and data type, so a single LoDTensorArray is enough to describe them.

However, since we are now trying to implement readers in C++, the support of multiple LoDTensorDesc in one VarDesc becomes necessary. In our design, a reader is held by a Variable, and of course, it can yield more than one LoDTensor once. These LoDTenosrs are likely to have distinct shapes, data types and LoDs. To describe all of them during the compile time, our VarDesc must be able to hold more than one LoDTensorDesc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant