Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some operators do not follow naming convention #5366

Closed
4 of 6 tasks
kexinzhao opened this issue Nov 3, 2017 · 1 comment
Closed
4 of 6 tasks

Some operators do not follow naming convention #5366

kexinzhao opened this issue Nov 3, 2017 · 1 comment
Assignees

Comments

@kexinzhao
Copy link
Contributor

kexinzhao commented Nov 3, 2017

Authors of operators should follow the name convention as detailed in here.

Below is the list of ops that does not follow parameter naming convention.
It is suggested that the main author of the operator fix the issue.

People can add to this list when they find applicable cases.

  • lstm_op (attribute names does not follow snake_case) ( @qingqing01 )
  • lstm_unit_op (Input name C_prev does not follow CamelCase) ( @zchen0211 )
  • momentum_op (attribute name useNesterov does not follow snake_case) ( @sidgoyal78 )
  • pool_op (some attribute names does not follow snake_case) ( @chengduoZH )
  • pool_with_index_op (some attribute names does not follow snake_case) ( @chengduoZH )
  • recurrent_op (input/output/attr names does not follow conventions) ( @reyoung )
@kexinzhao kexinzhao changed the title Some operators does not follow naming convention Some operators do not follow naming convention Nov 7, 2017
@qingqing01
Copy link
Contributor

The attribute names for lstm_op is fixed in #5429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants