New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Docker and Travis build.sh for Android #5169

Closed

wangkuiyi opened this issue Oct 27, 2017 · 2 comments

Assignees

Collaborator

wangkuiyi commented Oct 27, 2017

We have two build scripts for Android:

the one we use in Dockerfile.android: https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/scripts/docker/build_android.sh, and
the one we use with Travis-CI: https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/scripts/travis/build_android.sh

To keep the simplicity and consistency of the codebase, could we merge them into one?

wangkuiyi assigned Xreki and hedaoyuan

Contributor

Xreki commented Oct 30, 2017

Maybe we can add a build_android task on teamcity, then https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/scripts/travis/build_android.sh can be moved.

Contributor

Xreki commented Oct 30, 2017

But, teamcity seems slow for CI. #5051

Xreki added mobile labels

Xreki mentioned this issue

Try to add build_android task back to travis. #8699

Merged

Xreki closed this as completed in #8699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment