Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test WITH_GPU=OFF on travis #4476

Closed
luotao1 opened this issue Sep 28, 2017 · 3 comments
Closed

test WITH_GPU=OFF on travis #4476

luotao1 opened this issue Sep 28, 2017 · 3 comments

Comments

@luotao1
Copy link
Contributor

luotao1 commented Sep 28, 2017

We need to add ONLYCPU test on travis, in order to avoid compiler error like #4417 .
@luotao1 luotao1 changed the title test ONLYCPU on travis test WITH_GPU=OFF on travis Sep 29, 2017
@luotao1 luotao1 mentioned this issue Sep 29, 2017
Closed
@helinwang
Copy link
Contributor

helinwang commented Sep 29, 2017 •
edited
Loading

I added an extra step of WITH_GPU=OFF (to test ONLYCPU) into the TeamCity PR CI, the build time I tested increased from 15min to 17 min, seems reasonable. Please let me know if you think it's ok.

@luotao1
Copy link
Contributor Author

luotao1 commented Sep 30, 2017

the build time I tested increased from 15min to 17 min

That's reasonable. I think it's OK, thx very much! @helinwang

@pkuyym
Copy link
Contributor

pkuyym commented Oct 15, 2017

Close it due to solved. Please fail free to reopen it if necessary.

@pkuyym pkuyym closed this as completed Oct 15, 2017
@luotao1 luotao1 mentioned this issue Oct 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@helinwang @pkuyym @luotao1