Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Op test framework shall support ASSERT_THROW #4173

Closed
JiayiFeng opened this issue Sep 19, 2017 · 0 comments
Closed

Op test framework shall support ASSERT_THROW #4173

JiayiFeng opened this issue Sep 19, 2017 · 0 comments
Assignees
@reyoung

Comments

@JiayiFeng
Copy link
Collaborator

Most Ops are supposed to throw some kind of exceptions when size inferring fail or other error occurs. However, our current framework is not able to check the correctness of thrown exceptions. That makes our Op tests incomplete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reyoung reyoung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reyoung @JiayiFeng @shanyi15