Gometalinter too strict check when modifing master sources

[typhoonzero]

Updated master and pserver sources in #2948

Reporting:

master/c/client.go:54:6:warning: don't use underscores in Go names; func paddle_new_etcd_master_client should be paddleNewEtcdMasterClient (golint)
master/c/client.go:75:6:warning: don't use underscores in Go names; func paddle_new_master_client should be paddleNewMasterClient (golint)
master/c/client.go:84:6:warning: don't use underscores in Go names; func paddle_release_master_client should be paddleReleaseMasterClient (golint)
master/c/client.go:89:6:warning: don't use underscores in Go names; func paddle_set_dataset should be paddleSetDataset (golint)
master/c/client.go:111:6:warning: don't use underscores in Go names; func paddle_next_record should be paddleNextRecord (golint)
master/c/client.go:134:6:warning: don't use underscores in Go names; func mem_free should be memFree (golint)
pserver/client/c/cclient.go:90:6:warning: don't use underscores in Go names; func paddle_new_pserver_client should be paddleNewPserverClient (golint)
pserver/client/c/cclient.go:103:6:warning: don't use underscores in Go names; func paddle_new_etcd_pserver_client should be paddleNewEtcdPserverClient (golint)
pserver/client/c/cclient.go:112:6:warning: don't use underscores in Go names; func paddle_pserver_client_release should be paddlePserverClientRelease (golint)
pserver/client/c/cclient.go:117:6:warning: don't use underscores in Go names; func paddle_begin_init_params should be paddleBeginInitParams (golint)
pserver/client/c/cclient.go:126:6:warning: don't use underscores in Go names; func paddle_init_param should be paddleInitParam (golint)
pserver/client/c/cclient.go:150:6:warning: don't use underscores in Go names; func paddle_finish_init_params should be paddleFinishInitParams (golint)
pserver/client/c/cclient.go:167:6:warning: don't use underscores in Go names; func paddle_send_grads should be paddleSendGrads (golint)
pserver/client/c/cclient.go:188:6:warning: don't use underscores in Go names; func paddle_get_params should be paddleGetParams (golint)
pserver/client/c/cclient.go:246:6:warning: don't use underscores in Go names; func paddle_save_model should be paddleSaveModel (golint)
cmd/pserver/pserver.go:37:9:error: Checkpoint not declared by package pserver (gotype)
cmd/pserver/pserver.go:38:9:error: EtcdClient not declared by package pserver (gotype)
cmd/pserver/pserver.go:42:7:error: NewEtcdClient not declared by package pserver (gotype)
cmd/pserver/pserver.go:43:14:error: invalid operation: e (variable of type *invalid type) has no field or method Register (gotype)
cmd/pserver/pserver.go:46:13:error: NewCheckpointFromFile not declared by package pserver (gotype)
cmd/pserver/pserver.go:52:31:error: cannot use idx (variable of type int) as string value in argument to pserver.NewService (gotype)


cmd/pserver/pserver.go:52:57:error: too many arguments (gotype)
cmd/pserver/pserver.go:52:74:error: too many arguments (gotype)
pserver/client/c/cclient.go:33:2:error: could not import github.com/PaddlePaddle/Paddle/go/pserver/client (can't find import: github.com/PaddlePaddle/Paddle/go/pserver/client) (gotype)
pserver/client/c/cclient.go:38:51:error: undeclared name: client (gotype)
pserver/client/c/cclient.go:41:13:error: undeclared name: client (gotype)
pserver/client/c/cclient.go:50:43:error: undeclared name: client (gotype)
pserver/client/c/cclient.go:56:46:error: undeclared name: client (gotype)
pserver/client/c/cclient.go:83:15:error: undeclared name: client (gotype)
pserver/client/c/cclient.go:85:26:error: undeclared name: client (gotype)
pserver/client/c/cclient.go:93:20:error: undeclared name: client (gotype)
pserver/client/c/cclient.go:95:3:error: invalid operation: servers[i] (variable with invalid type) has no field or method Index (gotype)
pserver/client/c/cclient.go:96:3:error: invalid operation: servers[i] (variable with invalid type) has no field or method Addr (gotype)
pserver/client/c/cclient.go:98:7:error: undeclared name: client (gotype)


pserver/client/c/cclient.go:106:16:error: undeclared name: client (gotype)
pserver/client/c/cclient.go:107:7:error: undeclared name: client (gotype)
pserver/client/c/cclient.go:119:17:error: invalid operation: c (variable of type *invalid type) has no field or method BeginInitParams (gotype)
pserver/client/c/cclient.go:135:9:error: invalid operation: c (variable of type *invalid type) has no field or method InitParam (gotype)
pserver/client/c/cclient.go:152:9:error: invalid operation: c (variable of type *invalid type) has no field or method FinishInitParams (gotype)
pserver/client/c/cclient.go:178:9:error: invalid operation: c (variable of type *invalid type) has no field or method SendGrads (gotype)
pserver/client/c/cclient.go:195:13:error: invalid operation: c (variable of type *invalid type) has no field or method GetParams (gotype)


pserver/client/c/cclient.go:203:21:error: cannot range over ps (invalid operand) (gotype)
pserver/client/c/cclient.go:210:17:error: cannot range over ps (invalid operand) (gotype)
pserver/client/c/cclient.go:213:22:error: cannot range over ps (invalid operand) (gotype)
pserver/client/c/cclient.go:249:9:error: invalid operation: c (variable of type *invalid type) has no field or method Save (gotype)
pserver/client/etcd_client.go:70:13:error: PsPath not declared by package pserver (gotype)


  1 -   repo: https://github.com/Lucas-C/pre-commit-hooks.git
/Users/baidu/go/src/github.com/PaddlePaddle/Paddle
WARNING: deadline exceeded by linter errcheck on pserver/client/c (try increasing --deadline)
WARNING: deadline exceeded by linter errcheck on pserver (try increasing --deadline)
WARNING: deadline exceeded by linter errcheck on master/c (try increasing --deadline)
WARNING: deadline exceeded by linter errcheck on pserver/client (try increasing --deadline)
WARNING: deadline exceeded by linter errcheck on utils/networkhelper (try increasing --deadline)

[typhoonzero]

Fixed by updating https://github.com/PaddlePaddle/pre-commit-golang

[helinwang]

The error message is strange, since the CI passes.
For gotype

pserver/client/c/cclient.go:33:2:error: could not import github.com/PaddlePaddle/Paddle/go/pserver/client (can't find import: github.com/PaddlePaddle/Paddle/go/pserver/client) (gotype)

Feels like your code is not in $GOPATH, so go tool does not use the vendor folder. (see here: https://github.com/PaddlePaddle/pre-commit-golang/blob/master/run-gometalinter.sh#L2 )

For golint

master/c/client.go:54:6:warning: don't use underscores in Go names; func paddle_new_etcd_master_client should be paddleNewEtcdMasterClient (golint)

I did get this before, but it does not happen recently (probably because I updated golint), could you try to update golint?