Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Doc Bug: Interfacing to ROS · PX4 Developer Guide #391

Closed
jannsta1 opened this issue Dec 14, 2017 · 6 comments
Closed

Doc Bug: Interfacing to ROS · PX4 Developer Guide #391

jannsta1 opened this issue Dec 14, 2017 · 6 comments

Comments

@jannsta1
Copy link

DESCRIBE PROBLEM WITH DOCS HERE

I believe the line source Tools/setup_gazebo.bash $(pwd) $(pwd)/build/posix_sitl_default in the Launching Gazebo with ROS wrappers section of the referenced page should be modified to source Tools/setup_gazebo.bash $(pwd) $(pwd)/posix_sitl_default. At least in the branch I'm using (v1.6.5) the posix_sitl_default folder appears to be placed directly in the Firmware folder.

Perhaps this is supposed to be implied but took me quite a while to figure out why I couldn't get the mavros_posix_sitl.launch file to work properly.

Bug Page: Interfacing to ROS · PX4 Developer Guide

@jannsta1
Copy link
Author

My apologies, source Tools/setup_gazebo.bash $(pwd) $(pwd)/build_posix_sitl_default is what works in my environment.

@hamishwillee
Copy link
Collaborator

Thanks. I believe you're say we can close this :-).

Perhaps this is supposed to be implied but took me quite a while to figure out why I couldn't get the mavros_posix_sitl.launch file to work properly.

Can you offer any advice how we might make debugging this easier for people?

@jannsta1
Copy link
Author

I’m not sure of the mechanism that defines where the build code is placed so I’m not sure if there is a hard and fast rule for where it will be? Maybe add a comment on that line that the path may be .../“build_posix_sitl_default”?

Also, I found that setting the verbose flag on the roslaunch file helped me diagnose the problem. Perhaps adding a note about this would be a helpful general comment. Otherwise you don’t get any warnings that the motor plugins haven’t been found. I’d be tempted to add that flag into the code snippet.

Another nice to have would be how to integrate customised gazebo quadcopter models into the code base. Took me a bit to figure that out and I’m still not sure that I’m following best practices.

@mrivi
Copy link
Contributor

mrivi commented Dec 15, 2017

@jannsta1 ../build_posix_sitl_default is the old path to the built folder. It got changed to ../build/posix_sitl_default a couple of months ago. With the latest Firmware you should get ../build/posix_sitl_default.

@jannsta1
Copy link
Author

Ah OK, thanks @mrivi good to know.

@hamishwillee
Copy link
Collaborator

Thanks @jannsta1 - I added a note about the flag in #393 - see 80951e4

I'll look at your other points it that issue too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants