From db2b85cbd42c17ef581e62c8b2363b6fc37e9617 Mon Sep 17 00:00:00 2001 From: ultrasystem Date: Mon, 12 May 2014 21:17:19 +0800 Subject: [PATCH 1/2] Output a debug string is Invalid @ parameter #1 line 143 may be crash or buffer overflow. because the argument must is a pointer as char type that and have a valid buffer --- src/modules/systemlib/rc_check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/systemlib/rc_check.c b/src/modules/systemlib/rc_check.c index 21e15ec563c2..975944eb7556 100644 --- a/src/modules/systemlib/rc_check.c +++ b/src/modules/systemlib/rc_check.c @@ -140,7 +140,7 @@ int rc_calibration_check(int mavlink_fd) { /* sanity checks pass, enable channel */ if (count) { mavlink_log_critical(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1)); - warnx(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1)); + warnc(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1)); usleep(100000); } From ad51b4c24b624c32e31e4b3aad274d59e79f1b20 Mon Sep 17 00:00:00 2001 From: ultrasystem Date: Mon, 12 May 2014 23:08:34 +0800 Subject: [PATCH 2/2] Update paramters for warnx() --- src/modules/systemlib/rc_check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/systemlib/rc_check.c b/src/modules/systemlib/rc_check.c index 975944eb7556..c0c1a5cb4526 100644 --- a/src/modules/systemlib/rc_check.c +++ b/src/modules/systemlib/rc_check.c @@ -140,7 +140,7 @@ int rc_calibration_check(int mavlink_fd) { /* sanity checks pass, enable channel */ if (count) { mavlink_log_critical(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1)); - warnc(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1)); + warnx("ERROR: %d config error(s) for RC channel %d.", count, (i + 1)); usleep(100000); }