From 3f93b66a127504f1c567230cfd5d5a2b7dcf49f3 Mon Sep 17 00:00:00 2001 From: Aleksey Date: Tue, 19 Mar 2019 14:54:36 +0300 Subject: [PATCH 1/2] Misprints in parameters naming and description --- src/modules/fw_att_control/fw_att_control_params.c | 2 +- src/modules/vtol_att_control/standard.cpp | 2 +- src/modules/vtol_att_control/standard_params.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/modules/fw_att_control/fw_att_control_params.c b/src/modules/fw_att_control/fw_att_control_params.c index 0d8aebf1b524..15f7753bb14e 100644 --- a/src/modules/fw_att_control/fw_att_control_params.c +++ b/src/modules/fw_att_control/fw_att_control_params.c @@ -359,7 +359,7 @@ PARAM_DEFINE_FLOAT(FW_W_RMAX, 30.0f); * Roll rate feed forward * * Direct feed forward from rate setpoint to control surface output. Use this - * to obtain a tigher response of the controller without introducing + * to obtain a higher response of the controller without introducing * noise amplification. * * @unit %/rad/s diff --git a/src/modules/vtol_att_control/standard.cpp b/src/modules/vtol_att_control/standard.cpp index 7f37bc2f6935..d66f639bc4b8 100644 --- a/src/modules/vtol_att_control/standard.cpp +++ b/src/modules/vtol_att_control/standard.cpp @@ -60,7 +60,7 @@ Standard::Standard(VtolAttitudeControl *attc) : _mc_yaw_weight = 1.0f; _mc_throttle_weight = 1.0f; - _params_handles_standard.pusher_ramp_dt = param_find("VT_PSHER_RMP_DT"); + _params_handles_standard.pusher_ramp_dt = param_find("VT_PUSHER_RMP_DT"); _params_handles_standard.back_trans_ramp = param_find("VT_B_TRANS_RAMP"); _params_handles_standard.down_pitch_max = param_find("VT_DWN_PITCH_MAX"); _params_handles_standard.forward_thrust_scale = param_find("VT_FWD_THRUST_SC"); diff --git a/src/modules/vtol_att_control/standard_params.c b/src/modules/vtol_att_control/standard_params.c index 1427e5a07112..6116751e28dc 100644 --- a/src/modules/vtol_att_control/standard_params.c +++ b/src/modules/vtol_att_control/standard_params.c @@ -111,4 +111,4 @@ PARAM_DEFINE_FLOAT(VT_B_REV_DEL, 0.0f); * @decimal 2 * @group VTOL Attitude Control */ -PARAM_DEFINE_FLOAT(VT_PSHER_RMP_DT, 3.0f); +PARAM_DEFINE_FLOAT(VT_PUSHER_RMP_DT, 3.0f); From 4b9f3766a822fbfec70ab5daefd64ecfe9716b8b Mon Sep 17 00:00:00 2001 From: Aleksey Biryukov Date: Thu, 28 Mar 2019 14:00:36 +0300 Subject: [PATCH 2/2] Update fw_att_control_params.c change "higher" to "tighter" add an article before "voltage" --- src/modules/fw_att_control/fw_att_control_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/fw_att_control/fw_att_control_params.c b/src/modules/fw_att_control/fw_att_control_params.c index 15f7753bb14e..42971b40406c 100644 --- a/src/modules/fw_att_control/fw_att_control_params.c +++ b/src/modules/fw_att_control/fw_att_control_params.c @@ -359,7 +359,7 @@ PARAM_DEFINE_FLOAT(FW_W_RMAX, 30.0f); * Roll rate feed forward * * Direct feed forward from rate setpoint to control surface output. Use this - * to obtain a higher response of the controller without introducing + * to obtain a tighter response of the controller without introducing * noise amplification. * * @unit %/rad/s @@ -583,7 +583,7 @@ PARAM_DEFINE_FLOAT(FW_MAN_Y_SC, 1.0f); /** * Whether to scale throttle by battery power level * - * This compensates for voltage drop of the battery over time by attempting to + * This compensates for a voltage drop of the battery over time by attempting to * normalize performance across the operating range of the battery. The fixed wing * should constantly behave as if it was fully charged with reduced max thrust * at lower battery percentages. i.e. if cruise speed is at 0.5 throttle at 100% battery,