Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in profiling suite #2587

Merged
merged 4 commits into from
Apr 27, 2021

Conversation

chusloj
Copy link
Contributor

@chusloj chusloj commented Apr 21, 2021

This PR fixes in a bug in the profiling suite noticed in #2572. The profiling suite will no longer throw an error if new tests are introduced.

Thanks @jdebacker @amshoulders
cc @MattHJensen

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #2587 (18cf226) into master (d3c7037) will decrease coverage by 1.45%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2587      +/-   ##
==========================================
- Coverage   99.92%   98.46%   -1.46%     
==========================================
  Files          13       14       +1     
  Lines        2591     2611      +20     
==========================================
- Hits         2589     2571      -18     
- Misses          2       40      +38     
Flag Coverage Δ
unittests 98.46% <97.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
taxcalc/data.py 99.24% <66.66%> (-0.76%) ⬇️
taxcalc/__init__.py 100.00% <100.00%> (ø)
taxcalc/decorators.py 100.00% <100.00%> (ø)
taxcalc/parameters.py 99.31% <100.00%> (-0.02%) ⬇️
taxcalc/utils.py 97.79% <0.00%> (-2.21%) ⬇️
ppp.py 0.00% <0.00%> (ø)

@chusloj
Copy link
Contributor Author

chusloj commented Apr 21, 2021

@MattHJensen Loss of code coverage is for the same reasons described in #2584.

@MattHJensen
Copy link
Contributor

@MattHJensen Loss of code coverage is for the same reasons described in #2584.

Thanks for addressing this @chusloj. Could you help me understand why the codcov baseline wasn't updated with #2584?

@chusloj
Copy link
Contributor Author

chusloj commented Apr 23, 2021

why the codcov baseline wasn't updated

@MattHJensen I'm not sure – I'm not able to see the full codecov report on their website. I'm receiving different errors when I visit the report saying that I'm not allowed to view the report or that there's an error in Codecov's operations.

@MattHJensen MattHJensen merged commit cb0297d into PSLmodels:master Apr 27, 2021
@chusloj chusloj deleted the profiling_new_tests_bug branch April 27, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants