request to add (Tax change)/(Pre-reform after-tax income) to distributional tables

[MattHJensen]

Ernie Tedeschi requested on Twitter:

[andersonfrailey]

@MattHJensen, I can work on this

[andersonfrailey]

@MattHJensen, is something like the column aftertax_perc what you had in mind? If so I'll open the PR now (I tried to recreate the reform in the screen grab but I must be missing a parameter somewhere. Either way the idea stands).

[MattHJensen]

@andersonfrailey, could you try reposting the table? It isn't showing up for me:

[andersonfrailey]

@MattHJensen how about now?

[andersonfrailey]

It appears the screenshot I posted does not appear when using Chrome or Firefox. Here is a link to the notebook the screenshot is from.

[MattHJensen]

@andersonfrailey, could you make a notebook with a table for a top rate cut from 39.6 to 35 and a table w a doubling of the standard deduction?

[MattHJensen]

@andersonfrailey, could you also open a PR with the changes so we can review the code diffs?

[MattHJensen]

@andersonfrailey, could you also include a separate table in the notebook with avg expanded income by decile?

[andersonfrailey]

@MattHJensen, here is the notebook, but I'm having trouble with the PR.

In test_utils.py I get multiple attribution errors 'str' object has no attribbute 'closed'. I get the same error when running the tests on my master branch when I run py.test despite both being up to date with the origin. Should I open the PR anyway so others can see what might be going wrong?

[martinholmer]

Probably your taxcalc-dev conda environment is not up-to-date

…

Sent from my iPhone

On May 22, 2017, at 8:21 AM, andersonfrailey ***@***.***> wrote: @MattHJensen, here is the notebook, but I'm having trouble with the PR. In test_utils.py I get multiple attribution errors 'str' object has no attribbute 'closed'. I get the same error when running the tests on my master branch when I run py.test despite both being up to date with the origin. Should I open the PR anyway so others can see what might be going wrong? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[andersonfrailey]

Thanks, @martinholmer. Got it working.

[MattHJensen]

This is resolved. Closing.