Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated tests for flit update #248

Open
mikebentley15 opened this issue Dec 13, 2018 · 0 comments
Open

Automated tests for flit update #248

mikebentley15 opened this issue Dec 13, 2018 · 0 comments
Labels
bug good first issue A good place to start tests Involves touching tests

Comments

@mikebentley15
Copy link
Collaborator

Bug Report

Describe the problem
The flit update command-line tool (i.e. the flit_update.py script) does not have sufficient automated tests. There is a pull request for a new feature in there with automated tests for that feature, but there are existing features that need tests. The list I see now are:

  1. FLIT_INC_DIR, FLIT_LIB_DIR, FLIT_DATA_DIR, and FLIT_SCRIPT_DIR, for
    both from git repository and for an installed FLiT
  2. DEV_CC, DEV_OPTL, and DEV_SWITCHES for both provided and non-provided
  3. GT_CC, GT_OPTL, and GT_SWITCHES for both provided and non-provided
  4. TEST_RUN_ARGS from timing, timing_loops, and timing_repeats for both
    provided and non-provided
  5. ENABLE_MPI and MPIRUN_ARGS for both provided and non-provided
  6. HOSTNAME
  7. UNAME_S

Suggested Fix
Write either a large automated test for this or many small automated tests.

Alternative approaches:
Just don't test it as it is now, which isn't a good approach if we want to identify regressions.

@mikebentley15 mikebentley15 added bug good first issue A good place to start tests Involves touching tests labels Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue A good place to start tests Involves touching tests
Projects
None yet
Development

No branches or pull requests

1 participant