Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard make variable names #216

Closed
mikebentley15 opened this issue Sep 12, 2018 · 0 comments · Fixed by #281
Closed

Use standard make variable names #216

mikebentley15 opened this issue Sep 12, 2018 · 0 comments · Fixed by #281
Labels
documentation Involves touching documentation enhancement make Involves touching GNU Makefiles python Involves touching python code

Comments

@mikebentley15
Copy link
Collaborator

There are standard make variable names. Many projects adhere to them. They are used by the internal rules defined within GNU make, but I prefer not to depend on those since it is not very clear to many how those work, including me. I'd prefer to be explicit about what the makefile is supposed to do. However, we can still adhere to the convention of variable names, so that they can be overridden or appended in an expected way by the user.

See https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html

Variables of interest:

  • CXX
  • CXXFLAGS
  • LDFLAGS
  • LDLIBS

Another common variable to be overridden is the PREFIX variable when doing installations.

@mikebentley15 mikebentley15 added enhancement python Involves touching python code make Involves touching GNU Makefiles documentation Involves touching documentation labels Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Involves touching documentation enhancement make Involves touching GNU Makefiles python Involves touching python code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant