-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release plan for 0.9.0 #2689
Comments
I don't feel strongly about including it or not, I still think this is not a breaking change.
We can document it, with "Experimental" banner.
Probably the syntax changes have not been updated in the book. Also regex and integer division. |
I think we should document that "The int div operator and mod operator use truncated division". I'm in favor of introducing |
Another thing we should do — update the language grammars for the new syntax |
TBC on my perspective:
We can continue discussing on #2622... |
Well then let's not adapt |
As discussed on the dev call — we'll change the float division in generic to just |
Indentation — I'll put a PR in with 2 and we can decide on what looks best! |
Should this block on #2717 ? |
I think so. |
Another blocker: #2781 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
As I wrote here #2717 (comment), how about releasing without waiting for the issue to be resolved? |
Sorry for not having addressing this directly I agree we should try and release 0.9.0 as soon as possible. But I think it would be a bad experience if it's not ready:
I do think it's a better project if we "can release at any time", so we should try and make changes somewhat atomically; so, for example, the grammars don't fall out of date with the language. |
@max-sixty Thanks for your reply. Given that As for the grammar, I don't think it is actually part of the PRQL release. |
This is true, yes. But you don't think it would be confusing for the docs to be different from the version in VS Code? It's not so bad when it's a small change, but this will be very different, and so copying code between the two would be impossible.
I'm open-minded if others agree — what do folks think? (I also don't know how much work this would be to fix) Thanks for pushing on this @eitsupi ! |
|
Yes, on reflection, I agree. I was associating the errors in VS Code with the syntax highlighter, but they actually come from the parser... |
@aljazerzen Any thoughts on this? |
For the count s"*" we have a plan, it just needs to be implemented. Apart from that it would be nice to fix the windows overflow, but I don't hold that as a hard requirement. |
@aljazerzen would you want us to release before the I agree the Windows issue doesn't need to block. I'm still confused by it FWIW! |
I'd rather wait for s"*", since that is a change to the std module and will be changed again soon. The change should not take too much effort, at most a week. |
I think we can release. Docs can be updated later on. |
#3051 for post-mortem... |
What's up?
0.9.0 is probably going to be our biggest ever release. It'll include:
fmt
...and so many more items (that would at the top of the release notes of any other release)!
Given @aljazerzen is responsible for the vast majority of these, I'll handle the release.
Questions:
NULLS LAST
?The text was updated successfully, but these errors were encountered: